From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAC8E134B3 for ; Fri, 4 Aug 2023 15:35:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 176D5C433C7; Fri, 4 Aug 2023 15:35:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691163358; bh=cQbVZMK/+oE/3CK/u6/7Zqr0SXiVGxH3ROY1UV0fNX8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J8moY05okVRv86wuUbFDhMkLLt15SDi8maNVhLU4Ol14LWWPW3EMrOFiMVag7d8I4 IsZb9iBlZ29WLWmyJVYLmhJsuvquDaUzKGGAmWgPJGX9I+9ubwM83dDCoj4rSXfAU+ AQUxD4YP9NWNJbx/vOUQaDjCbMTzguV59oBKSosyAqOYJpTExQGI1ytda5prxdVYQF BTKAQZmzQyqGYqHrpbbHXViEW/SS3HFOE9VpBMTPPyeakOA+64czmVdN6F3VT1K73K blJ3Vlg89ewIN/g6k8NPB0yGJ43aNjPB+SuJLS+SV/AyvsWUMCLG/0hVQN2KLINlpP 8A4hY/KB/1sfA== Date: Fri, 4 Aug 2023 16:35:51 +0100 From: Conor Dooley To: Md Danish Anwar Cc: MD Danish Anwar , Randy Dunlap , Roger Quadros , Simon Horman , Vignesh Raghavendra , Andrew Lunn , Richard Cochran , Conor Dooley , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , nm@ti.com, srk@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/4] dt-bindings: net: Add ICSS IEP Message-ID: <20230804-uncombed-escalate-d46b38ce37a2@spud> References: <20230803110153.3309577-1-danishanwar@ti.com> <20230803110153.3309577-2-danishanwar@ti.com> <20230803-guacamole-buddy-d8179f11615e@spud> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3mKgAWLJHpCzOPKl" Content-Disposition: inline In-Reply-To: --3mKgAWLJHpCzOPKl Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Aug 04, 2023 at 11:56:19AM +0530, Md Danish Anwar wrote: > Hi Conor, >=20 > On 03/08/23 8:57 pm, Conor Dooley wrote: > > On Thu, Aug 03, 2023 at 04:31:50PM +0530, MD Danish Anwar wrote: > >> From: Md Danish Anwar > >> > >> Add DT binding documentation for ICSS IEP module. > >> > >> Signed-off-by: Md Danish Anwar > >> --- > >> .../devicetree/bindings/net/ti,icss-iep.yaml | 37 +++++++++++++++++++ > >> 1 file changed, 37 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/net/ti,icss-iep.= yaml > >> > >> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml b/= Documentation/devicetree/bindings/net/ti,icss-iep.yaml > >> new file mode 100644 > >> index 000000000000..79cd72b330a6 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml > >> @@ -0,0 +1,37 @@ > >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >> +%YAML 1.2 > >> +--- > >> +$id: http://devicetree.org/schemas/net/ti,icss-iep.yaml# > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >> + > >> +title: Texas Instruments ICSS Industrial Ethernet Peripheral (IEP) mo= dule > >> + > >> +maintainers: > >> + - Md Danish Anwar > >> + > >> +properties: > >> + compatible: > >> + enum: > >> + - ti,am654-icss-iep # for K3 AM65x, J721E and AM64x SoCs > >=20 > > No. ti,am654-icss-iep is for am654. You should really have compatibles > > specific to the SoC - is there a reason why this has not been done? > >=20 >=20 > Yes, ti,am654-icss-iep is for am654. You are right, the compatibles shoul= d be > specific to SoC. Currently the upstream support is being added for only A= M65x. >=20 > I will remove J721E and AM64x SoCs from the comment above and these compa= tibles > when their support is enabled in future. So the comment was totally wrong? Or does the same code work for all 3 of these SoC types & you used the same compatible on each of the 3? Thanks, Conor. > Below is the updated compatible property. >=20 > properties: > compatible: > enum: > - ti,am654-icss-iep # for K3 AM65x SoCs --3mKgAWLJHpCzOPKl Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZM0a1wAKCRB4tDGHoIJi 0kZLAQDt0yOMq+c+G7AcANr7kuJDAC5wZyoKewJmytYeOKITywEAxxaoRDlceLUD irO27APk1pQvWbA9qMb6vB02LrMZ/go= =seKc -----END PGP SIGNATURE----- --3mKgAWLJHpCzOPKl--