From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org,
Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
Peilin Ye <yepeilin.cs@gmail.com>,
Pedro Tammela <pctammela@mojatatu.com>,
Richard Cochran <richardcochran@gmail.com>,
Zhengchao Shao <shaozhengchao@huawei.com>,
Maxim Georgiev <glipus@gmail.com>
Subject: Re: [PATCH v3 net-next 09/10] selftests/tc-testing: test that taprio can only be attached as root
Date: Mon, 7 Aug 2023 22:06:02 +0300 [thread overview]
Message-ID: <20230807190602.pvforrful3zmqiv6@skbuf> (raw)
In-Reply-To: <87il9w0xx7.fsf@intel.com>
On Thu, Aug 03, 2023 at 11:43:16AM -0700, Vinicius Costa Gomes wrote:
> Hmmm, I think that this test discovered another bug (perhaps even two).
> When it fails here's the json I get (edited for clarity):
>
> [{"kind":"taprio","handle":"8001:","root":true,"refcnt":9,
> "options":{
> "tc":0,
> "map":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0],
> "queues":[],
> "clockid":"TAI",
> "base_time":0,
> "cycle_time":0,
> "cycle_time_extension":0,
> {
> "base_time":0,
> "cycle_time":20000000,
> "cycle_time_extension":0,
> "schedule":[{"index":0,"cmd":"S","gatemask":"0xff","interval":20000000}]
> }}}]
>
> Thinking out loud: If I am reading this right, there's no "oper"
> schedule, only an "admin" schedule. So the first bug is probably a
> taprio bug when deciding if it should create an "open" vs. "admin"
> schedule.
>
> The second bug seems to be in the way that q_taprio in iproute2
> handles the admin schedule, is just an object inside another, which
> seems to be invalid.
>
> Does it make sense?
Yes, it makes sense, thanks. I've sent some iproute2 patches that fix
the user space issues, and I'll soon send a v4 which takes into
consideration the fact that the admin schedule may not become
operational right away.
https://patchwork.kernel.org/project/netdevbpf/patch/20230807160827.4087483-1-vladimir.oltean@nxp.com/
next prev parent reply other threads:[~2023-08-07 19:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 18:24 [PATCH v3 net-next 00/10] Improve the taprio qdisc's relationship with its children Vladimir Oltean
2023-08-01 18:24 ` [PATCH v3 net-next 01/10] net/sched: taprio: don't access q->qdiscs[] in unoffloaded mode during attach() Vladimir Oltean
2023-08-01 18:24 ` [PATCH v3 net-next 02/10] net/sched: taprio: keep child Qdisc refcount elevated at 2 in offload mode Vladimir Oltean
2023-08-01 18:24 ` [PATCH v3 net-next 03/10] net/sched: taprio: try again to report q->qdiscs[] to qdisc_leaf() Vladimir Oltean
2023-08-01 18:24 ` [PATCH v3 net-next 04/10] net/sched: taprio: delete misleading comment about preallocating child qdiscs Vladimir Oltean
2023-08-01 18:24 ` [PATCH v3 net-next 05/10] net/sched: taprio: dump class stats for the actual q->qdiscs[] Vladimir Oltean
2023-08-01 18:24 ` [PATCH v3 net-next 06/10] net: ptp: create a mock-up PTP Hardware Clock driver Vladimir Oltean
2023-08-02 12:18 ` Kurt Kanzenbach
2023-08-02 12:43 ` Vladimir Oltean
2023-08-02 21:58 ` Vinicius Costa Gomes
2023-08-03 14:45 ` Vladimir Oltean
2023-08-01 18:24 ` [PATCH v3 net-next 07/10] net: netdevsim: use mock PHC driver Vladimir Oltean
2023-08-01 18:24 ` [PATCH v3 net-next 08/10] net: netdevsim: mimic tc-taprio offload Vladimir Oltean
2023-08-01 18:24 ` [PATCH v3 net-next 09/10] selftests/tc-testing: test that taprio can only be attached as root Vladimir Oltean
2023-08-02 23:29 ` Vinicius Costa Gomes
2023-08-03 14:33 ` Vladimir Oltean
2023-08-03 18:43 ` Vinicius Costa Gomes
2023-08-07 19:06 ` Vladimir Oltean [this message]
2023-08-03 17:21 ` Victor Nogueira
2023-08-04 11:14 ` Vladimir Oltean
2023-08-01 18:24 ` [PATCH v3 net-next 10/10] selftests/tc-testing: verify that a qdisc can be grafted onto a taprio class Vladimir Oltean
2023-08-03 10:04 ` [Intel-wired-lan] [PATCH v3 net-next 00/10] Improve the taprio qdisc's relationship with its children Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807190602.pvforrful3zmqiv6@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=glipus@gmail.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muhammad.husaini.zulkifli@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=richardcochran@gmail.com \
--cc=shaozhengchao@huawei.com \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox