From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Alex Elder <elder@linaro.org>,
Srini Kandagatla <srinivas.kandagatla@linaro.org>,
Andrew Halaney <ahalaney@redhat.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Subject: [PATCH 5/9] arm64: dts: qcom: sa8775p-ride: move the reset-gpios property of the PHY
Date: Mon, 7 Aug 2023 21:35:03 +0200 [thread overview]
Message-ID: <20230807193507.6488-6-brgl@bgdev.pl> (raw)
In-Reply-To: <20230807193507.6488-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Device-tree bindings for MDIO define per-PHY reset-gpios as well as a
global reset-gpios property at the MDIO node level which controlls all
devices on the bus. The latter is most likely a workaround for the
chicken-and-egg problem where we cannot read the ID of the PHY before
bringing it out of reset but we cannot bring it out of reset until we've
read its ID.
I have proposed a solution for this problem in 2020 but it never got
upstream. Now we have a workaround in place which allows us to hard-code
the PHY id in the compatible property, thus skipping the ID scanning).
Let's make the device-tree for sa8775p-ride slightly more correct by
moving the reset-gpios property to the PHY node with its ID put into the
PHY node's compatible.
Link: https://lore.kernel.org/all/20200622093744.13685-1-brgl@bgdev.pl/
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
index 38327aff18b0..1c471278d441 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
@@ -279,13 +279,12 @@ mdio {
#address-cells = <1>;
#size-cells = <0>;
- reset-gpios = <&pmm8654au_2_gpios 8 GPIO_ACTIVE_LOW>;
- reset-delay-us = <11000>;
- reset-post-delay-us = <70000>;
-
sgmii_phy: phy@8 {
+ compatible = "ethernet-phy-id0141.0dd4";
reg = <0x8>;
device_type = "ethernet-phy";
+ reset-gpios = <&pmm8654au_2_gpios 8 GPIO_ACTIVE_LOW>;
+ reset-deassert-us = <70000>;
};
};
--
2.39.2
next prev parent reply other threads:[~2023-08-07 19:35 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 19:34 [PATCH 0/9] arm64: dts: qcom: enable EMAC1 on sa8775p Bartosz Golaszewski
2023-08-07 19:34 ` [PATCH 1/9] arm64: dts: qcom: sa8775p: add a node for the second serdes PHY Bartosz Golaszewski
2023-08-07 21:10 ` Andrew Halaney
2023-08-07 21:28 ` Andrew Lunn
2023-08-07 21:39 ` Andrew Halaney
2023-08-07 21:48 ` Andrew Lunn
2023-08-07 19:35 ` [PATCH 2/9] arm64: dts: qcom: sa8775p: add a node for EMAC1 Bartosz Golaszewski
2023-08-07 21:13 ` Andrew Halaney
2023-08-07 19:35 ` [PATCH 3/9] arm64: dts: qcom: sa8775p-ride: enable the second SerDes PHY Bartosz Golaszewski
2023-08-07 21:15 ` Andrew Halaney
2023-08-07 19:35 ` [PATCH 4/9] arm64: dts: qcom: sa8775p-ride: add pin functions for ethernet1 Bartosz Golaszewski
2023-08-07 21:18 ` Andrew Halaney
2023-08-07 21:39 ` Andrew Lunn
2023-08-07 19:35 ` Bartosz Golaszewski [this message]
2023-08-07 21:32 ` [PATCH 5/9] arm64: dts: qcom: sa8775p-ride: move the reset-gpios property of the PHY Andrew Halaney
2023-08-07 21:51 ` Andrew Lunn
2023-08-07 22:27 ` Andrew Halaney
2023-08-08 12:16 ` Bartosz Golaszewski
2023-08-08 14:27 ` Andrew Halaney
2023-08-08 13:17 ` Andrew Lunn
2023-08-07 19:35 ` [PATCH 6/9] arm64: dts: qcom: sa8775p-ride: index the first SGMII PHY Bartosz Golaszewski
2023-08-07 21:41 ` Andrew Halaney
2023-08-07 19:35 ` [PATCH 7/9] arm64: dts: qcom: sa8775p-ride: add the second " Bartosz Golaszewski
2023-08-07 21:47 ` Andrew Halaney
2023-08-07 19:35 ` [PATCH 8/9] arm64: dts: qcom: sa8775p-ride: label the mdio node Bartosz Golaszewski
2023-08-07 19:35 ` [PATCH 9/9] arm64: dts: qcom: sa8775p-ride: enable EMAC1 Bartosz Golaszewski
2023-08-07 20:03 ` Andrew Lunn
2023-08-07 21:50 ` Andrew Halaney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230807193507.6488-6-brgl@bgdev.pl \
--to=brgl@bgdev.pl \
--cc=agross@kernel.org \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).