From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6A15217AA1 for ; Mon, 7 Aug 2023 21:26:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EEAAC433C9; Mon, 7 Aug 2023 21:26:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691443578; bh=32H+SFOGjkQzZoSa4CTQjr3UAOc/ko2lldBhq1l87xs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=iJ7z2hXoHY08ki3SRMX5Gc1jk/0So9vZKZNQDmrjIMVoruhhZgdbY/33FHKFRH+OF kNfDTBK4Ekz715khISbwUdyJvIaZnmT3XvlvmHIE6Lsuk9iDP277ECuzQxfA63Ft/F wm4pK6TCEznrBhjEr6WTeWw2Ji15i1xbwnHNsOzLYkVE4kwpMoIHNdfEGICMt7gmsR ujlBeM10TD35jVShUhpOef4E6Co0CzYifIM69GhSafDczHCligHT9COKb4lHpxhnK7 UO+b6ye9zVUKm/nqzLGGmjxFALwkgJ+I5QfiSYiBIHb9jmTgurmQ5pRyLDloik5PMy zr4SNsBWTT7Ew== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet Cc: Saeed Mahameed , netdev@vger.kernel.org, Tariq Toukan , Daniel Jurgens Subject: [net 04/11] net/mlx5: Return correct EC_VF function ID Date: Mon, 7 Aug 2023 14:26:00 -0700 Message-ID: <20230807212607.50883-5-saeed@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230807212607.50883-1-saeed@kernel.org> References: <20230807212607.50883-1-saeed@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Daniel Jurgens The ECVF function ID range is 1..max_ec_vfs. Currently mlx5_vport_to_func_id returns 0..max_ec_vfs - 1. Which results in a syndrome when querying the caps with more recent firmware, or reading incorrect caps with older firmware that supports EC VFs. Fixes: 9ac0b128248e ("net/mlx5: Update vport caps query/set for EC VFs") Signed-off-by: Daniel Jurgens Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h b/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h index c4be257c043d..682d3dc00dd1 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h +++ b/drivers/net/ethernet/mellanox/mlx5/core/mlx5_core.h @@ -361,7 +361,7 @@ static inline bool mlx5_core_is_ec_vf_vport(const struct mlx5_core_dev *dev, u16 static inline int mlx5_vport_to_func_id(const struct mlx5_core_dev *dev, u16 vport, bool ec_vf_func) { - return ec_vf_func ? vport - mlx5_core_ec_vf_vport_base(dev) + return ec_vf_func ? vport - mlx5_core_ec_vf_vport_base(dev) + 1 : vport; } -- 2.41.0