netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeed@kernel.org>
To: "David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Eric Dumazet <edumazet@google.com>
Cc: Saeed Mahameed <saeedm@nvidia.com>,
	netdev@vger.kernel.org, Tariq Toukan <tariqt@nvidia.com>,
	Daniel Jurgens <danielj@nvidia.com>
Subject: [net 05/11] net/mlx5: Allow 0 for total host VFs
Date: Mon,  7 Aug 2023 14:26:01 -0700	[thread overview]
Message-ID: <20230807212607.50883-6-saeed@kernel.org> (raw)
In-Reply-To: <20230807212607.50883-1-saeed@kernel.org>

From: Daniel Jurgens <danielj@nvidia.com>

When querying eswitch functions 0 is a valid number of host VFs. After
introducing ARM SRIOV falling through to getting the max value from PCI
results in using the total VFs allowed on the ARM for the host.

Fixes: 86eec50beaf3 ("net/mlx5: Support querying max VFs from device");
Signed-off-by: Daniel Jurgens <danielj@nvidia.com>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/sriov.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
index 4e42a3b9b8ee..a2fc937d5461 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/sriov.c
@@ -285,8 +285,7 @@ static u16 mlx5_get_max_vfs(struct mlx5_core_dev *dev)
 		host_total_vfs = MLX5_GET(query_esw_functions_out, out,
 					  host_params_context.host_total_vfs);
 		kvfree(out);
-		if (host_total_vfs)
-			return host_total_vfs;
+		return host_total_vfs;
 	}
 
 done:
-- 
2.41.0


  parent reply	other threads:[~2023-08-07 21:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-07 21:25 [pull request][net 00/11] mlx5 fixes 2023-08-07 Saeed Mahameed
2023-08-07 21:25 ` [net 01/11] net/mlx5e: Take RTNL lock when needed before calling xdp_set_features() Saeed Mahameed
2023-08-08 23:40   ` patchwork-bot+netdevbpf
2023-08-07 21:25 ` [net 02/11] net/mlx5e: TC, Fix internal port memory leak Saeed Mahameed
2023-08-07 21:25 ` [net 03/11] net/mlx5: DR, Fix wrong allocation of modify hdr pattern Saeed Mahameed
2023-08-07 21:26 ` [net 04/11] net/mlx5: Return correct EC_VF function ID Saeed Mahameed
2023-08-07 21:26 ` Saeed Mahameed [this message]
2023-08-07 21:26 ` [net 06/11] net/mlx5: Fix devlink controller number for ECVF Saeed Mahameed
2023-08-07 21:26 ` [net 07/11] net/mlx5e: Unoffload post act rule when handling FIB events Saeed Mahameed
2023-08-07 21:26 ` [net 08/11] net/mlx5: LAG, Check correct bucket when modifying LAG Saeed Mahameed
2023-08-07 21:26 ` [net 09/11] net/mlx5: Skip clock update work when device is in error state Saeed Mahameed
2023-08-07 21:26 ` [net 10/11] net/mlx5: Reload auxiliary devices in pci error handlers Saeed Mahameed
2023-08-07 21:26 ` [net 11/11] net/mlx5e: Add capability check for vnic counters Saeed Mahameed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230807212607.50883-6-saeed@kernel.org \
    --to=saeed@kernel.org \
    --cc=danielj@nvidia.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=tariqt@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).