From: Ido Schimmel <idosch@nvidia.com>
To: <netdev@vger.kernel.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>,
<edumazet@google.com>, <dsahern@kernel.org>, <petrm@nvidia.com>,
Ido Schimmel <idosch@nvidia.com>
Subject: [PATCH net 0/3] nexthop: Nexthop dump fixes
Date: Tue, 8 Aug 2023 10:52:30 +0300 [thread overview]
Message-ID: <20230808075233.3337922-1-idosch@nvidia.com> (raw)
Patches #1 and #3 fix two problems related to nexthops and nexthop
buckets dump, respectively. Patch #2 is a preparation for the third
patch.
The pattern described in these patches of splitting the NLMSG_DONE to a
separate response is prevalent in other rtnetlink dump callbacks. I
don't know if it's because I'm missing something or if this was done
intentionally to ensure the message is delivered to user space. After
commit 0642840b8bb0 ("af_netlink: ensure that NLMSG_DONE never fails in
dumps") this is no longer necessary and I can improve these dump
callbacks assuming this analysis is correct.
No regressions in existing tests:
# ./fib_nexthops.sh
[...]
Tests passed: 230
Tests failed: 0
Ido Schimmel (3):
nexthop: Fix infinite nexthop dump when using maximum nexthop ID
nexthop: Make nexthop bucket dump more efficient
nexthop: Fix infinite nexthop bucket dump when using maximum nexthop
ID
net/ipv4/nexthop.c | 28 ++++++---------------
tools/testing/selftests/net/fib_nexthops.sh | 10 ++++++++
2 files changed, 17 insertions(+), 21 deletions(-)
--
2.40.1
next reply other threads:[~2023-08-08 15:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 7:52 Ido Schimmel [this message]
2023-08-08 7:52 ` [PATCH net 1/3] nexthop: Fix infinite nexthop dump when using maximum nexthop ID Ido Schimmel
2023-08-08 14:53 ` David Ahern
2023-08-08 7:52 ` [PATCH net 2/3] nexthop: Make nexthop bucket dump more efficient Ido Schimmel
2023-08-08 14:53 ` David Ahern
2023-08-08 7:52 ` [PATCH net 3/3] nexthop: Fix infinite nexthop bucket dump when using maximum nexthop ID Ido Schimmel
2023-08-08 14:54 ` David Ahern
2023-08-09 21:00 ` [PATCH net 0/3] nexthop: Nexthop dump fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808075233.3337922-1-idosch@nvidia.com \
--to=idosch@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).