From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DDC21156CB for ; Tue, 8 Aug 2023 18:56:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DC9C6C433C9; Tue, 8 Aug 2023 18:56:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691520967; bh=X7+ZlYY0FSROiWpD/bKqog6jgK40bS0uWHHjKh6wWlQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=tDG9QJkLhPbqqQfBzt3N7r2dsveLSfJMqJQfcq0fGicrdcP6y78WcyFNVY21Ax8h2 xFWsWEeiADuI5XUFS3VMfpTD8uKILykVo32nUMolFaKIW2gRP1f/D/pgT4KQ3WAaq5 f5epbNJZuODx4njaDNqmunIVfXtw+XWFGFh6yi9Aj9DA962USo9mS/DDPeUIWLIAuF K2B1YZwIHghG31iZS5eaGN2fifNyuh1XCAlL1DexxeTRTdM5hsw8n60uC0lrkn5QC/ Le3r2umH3AE1Hbyct6+Oth8getUwyIa9G9uIyc8PvVPq/FN216Ju1RnHtDN5B57Ju2 HPBmj5nge99iA== Date: Tue, 8 Aug 2023 21:56:01 +0300 From: Leon Romanovsky To: Petr Pavlu Cc: tariqt@nvidia.com, yishaih@nvidia.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jgg@ziepe.ca, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 04/10] mlx4: Get rid of the mlx4_interface.activate callback Message-ID: <20230808185601.GI94631@unreal> References: <20230804150527.6117-1-petr.pavlu@suse.com> <20230804150527.6117-5-petr.pavlu@suse.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230804150527.6117-5-petr.pavlu@suse.com> On Fri, Aug 04, 2023 at 05:05:21PM +0200, Petr Pavlu wrote: > The mlx4_interface.activate callback was introduced in commit > 79857cd31fe7 ("net/mlx4: Postpone the registration of net_device"). It > dealt with a situation when a netdev notifier received a NETDEV_REGISTER > event for a new net_device created by mlx4_en but the same device was > not yet visible to mlx4_get_protocol_dev(). The callback can be removed > now that mlx4_get_protocol_dev() is gone. > > Signed-off-by: Petr Pavlu > Tested-by: Leon Romanovsky > --- > drivers/net/ethernet/mellanox/mlx4/en_main.c | 37 +++++++++----------- > drivers/net/ethernet/mellanox/mlx4/intf.c | 2 -- > include/linux/mlx4/driver.h | 1 - > 3 files changed, 16 insertions(+), 24 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky