From: Jakub Kicinski <kuba@kernel.org>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
daniel@iogearbox.net, andrii@kernel.org, ast@kernel.org,
netdev@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: pull-request: bpf-next 2023-08-09
Date: Thu, 10 Aug 2023 14:33:13 -0700 [thread overview]
Message-ID: <20230810143313.016929c5@kernel.org> (raw)
In-Reply-To: <b3d4972e-2a08-d627-db2f-64dfd4e96bde@linux.dev>
On Thu, 10 Aug 2023 14:26:01 -0700 Martin KaFai Lau wrote:
> On 8/10/23 2:19 PM, Jakub Kicinski wrote:
> > On Wed, 9 Aug 2023 22:51:23 -0700 Martin KaFai Lau wrote:
> >> bpf: fix bpf_dynptr_slice() to stop return an ERR_PTR.
> >
> > This one looks like solid bpf material TBH, any reason it's here?
>
> There is an earlier bpf_dynptr_check_off_len() call which should have caught
> that already, so ERR_PTR case should not happen.
> https://lore.kernel.org/bpf/e0e8bf3b-70af-3827-2fa3-30f3d48bcf46@linux.dev/
That kind of info needs to be in the commit message :(
next prev parent reply other threads:[~2023-08-10 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 5:51 pull-request: bpf-next 2023-08-09 Martin KaFai Lau
2023-08-10 21:19 ` Jakub Kicinski
2023-08-10 21:26 ` Martin KaFai Lau
2023-08-10 21:33 ` Jakub Kicinski [this message]
2023-08-10 21:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810143313.016929c5@kernel.org \
--to=kuba@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).