Re: [PATCH net v2 09/17] selftests: forwarding: hw_stats_l3_gre: Skip when using veth pairs

Ido Schimmel
2023-08-09T05:46:10Z

On Wed, Aug 09, 2023 at 10:02:22AM +0800, Hangbin Liu wrote:
> On Tue, Aug 08, 2023 at 05:14:55PM +0300, Ido Schimmel wrote:
> > Layer 3 hardware stats cannot be used when the underlying interfaces are
> > veth pairs, resulting in failures:
> >
> > # ./hw_stats_l3_gre.sh
> > TEST: ping gre flat [ OK ]
> > TEST: Test rx packets: [FAIL]
> > Traffic not reflected in the counter: 0 -> 0
> > TEST: Test tx packets: [FAIL]
> > Traffic not reflected in the counter: 0 -> 0
> >
> > Fix by skipping the test when used with veth pairs.
> >
> > Fixes: 813f97a26860 ("selftests: forwarding: Add a tunnel-based test for L3 HW stats")
> > Reported-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
> > Closes: https://lore.kernel.org/netdev/adc5e40d-d040-a65e-eb26-edf47dac5b02@alu.unizg.hr/
> > Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> > Reviewed-by: Petr Machata <petrm@nvidia.com>
> > Tested-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
> > ---
> > tools/testing/selftests/net/forwarding/hw_stats_l3_gre.sh | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/tools/testing/selftests/net/forwarding/hw_stats_l3_gre.sh b/tools/testing/selftests/net/forwarding/hw_stats_l3_gre.sh
> > index eb9ec4a68f84..7594bbb49029 100755
> > --- a/tools/testing/selftests/net/forwarding/hw_stats_l3_gre.sh
> > +++ b/tools/testing/selftests/net/forwarding/hw_stats_l3_gre.sh
> > @@ -99,6 +99,8 @@ test_stats_rx()
> > test_stats g2a rx
> > }
> >
> > +skip_on_veth
> > +
> > trap cleanup EXIT
> >
> > setup_prepare
>
> Petr has been add a veth check for this script in a9fda7a0b033 ("selftests:
> forwarding: hw_stats_l3: Detect failure to install counters"). I think we can
> remove it with your patch?

Yes, I plan to remove it in net-next.