Re: [PATCH net v2 10/17] selftests: forwarding: ethtool_mm: Skip when MAC Merge is not supported

Vladimir Oltean
2023-08-10T17:29:05Z

On Tue, Aug 08, 2023 at 05:14:56PM +0300, Ido Schimmel wrote:
> MAC Merge cannot be tested with veth pairs, resulting in failures:
>
> # ./ethtool_mm.sh
> [...]
> TEST: Manual configuration with verification: swp1 to swp2 [FAIL]
> Verification did not succeed
>
> Fix by skipping the test when the interfaces do not support MAC Merge.
>
> Fixes: e6991384ace5 ("selftests: forwarding: add a test for MAC Merge layer")
> Reported-by: Mirsad Todorovac <mirsad.todorovac@alu.unizg.hr>
> Closes: https://lore.kernel.org/netdev/adc5e40d-d040-a65e-eb26-edf47dac5b02@alu.unizg.hr/
> Signed-off-by: Ido Schimmel <idosch@nvidia.com>
> ---
> Cc: vladimir.oltean@nxp.com
> v2:
> Probe for MAC Merge support.
> ---

Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Tested-by: Vladimir Oltean <vladimir.oltean@nxp.com>