From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
edumazet@google.com, moshe@nvidia.com, saeedm@nvidia.com,
idosch@nvidia.com, petrm@nvidia.com
Subject: Re: [patch net-next v3 10/13] devlink: allow user to narrow per-instance dumps by passing handle attrs
Date: Thu, 10 Aug 2023 19:17:22 -0700 [thread overview]
Message-ID: <20230810191722.7c19f190@kernel.org> (raw)
In-Reply-To: <20230810131539.1602299-11-jiri@resnulli.us>
On Thu, 10 Aug 2023 15:15:36 +0200 Jiri Pirko wrote:
> + struct nlattr **attrs = info->attrs;
> + int flags = NLM_F_MULTI;
> +
> + if (attrs)
> + flags |= NLM_F_DUMP_FILTERED;
Are attrs NULL if user passed no TLVs?
TBH I'm not sure how valuable NLM_F_DUMP_FILTERED is in the first place.
next prev parent reply other threads:[~2023-08-11 2:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 13:15 [patch net-next v3 00/13] devlink: introduce selective dumps Jiri Pirko
2023-08-10 13:15 ` [patch net-next v3 01/13] devlink: parse linecard attr in doit() callbacks Jiri Pirko
2023-08-10 13:15 ` [patch net-next v3 02/13] devlink: parse rate attrs " Jiri Pirko
2023-08-10 13:15 ` [patch net-next v3 03/13] devlink: introduce devlink_nl_pre_doit_port*() helper functions Jiri Pirko
2023-08-10 13:15 ` [patch net-next v3 04/13] devlink: rename doit callbacks for per-instance dump commands Jiri Pirko
2023-08-10 13:15 ` [patch net-next v3 05/13] devlink: introduce dumpit callbacks for split ops Jiri Pirko
2023-08-10 13:15 ` [patch net-next v3 06/13] devlink: pass flags as an arg of dump_one() callback Jiri Pirko
2023-08-10 13:15 ` [patch net-next v3 07/13] netlink: specs: devlink: add commands that do per-instance dump Jiri Pirko
2023-08-10 13:15 ` [patch net-next v3 08/13] devlink: remove duplicate temporary netlink callback prototypes Jiri Pirko
2023-08-10 13:15 ` [patch net-next v3 09/13] devlink: remove converted commands from small ops Jiri Pirko
2023-08-10 13:15 ` [patch net-next v3 10/13] devlink: allow user to narrow per-instance dumps by passing handle attrs Jiri Pirko
2023-08-11 2:17 ` Jakub Kicinski [this message]
2023-08-11 8:41 ` Jiri Pirko
2023-08-10 13:15 ` [patch net-next v3 11/13] netlink: specs: devlink: extend per-instance dump commands to accept instance attributes Jiri Pirko
2023-08-10 13:15 ` [patch net-next v3 12/13] devlink: extend health reporter dump selector by port index Jiri Pirko
2023-08-10 13:15 ` [patch net-next v3 13/13] netlink: specs: devlink: extend health reporter dump attributes " Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230810191722.7c19f190@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiri@resnulli.us \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).