From: kernel test robot <lkp@intel.com>
To: Eric Dumazet <edumazet@google.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: oe-kbuild-all@lists.linux.dev,
Simon Horman <simon.horman@corigine.com>,
Soheil Hassas Yeganeh <soheil@google.com>,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH net-next 09/15] inet: move inet->transparent to inet->inet_flags
Date: Thu, 10 Aug 2023 21:45:17 +0800 [thread overview]
Message-ID: <202308102127.hRNurJL6-lkp@intel.com> (raw)
In-Reply-To: <20230810103927.1705940-10-edumazet@google.com>
Hi Eric,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/inet-introduce-inet-inet_flags/20230810-184815
base: net-next/main
patch link: https://lore.kernel.org/r/20230810103927.1705940-10-edumazet%40google.com
patch subject: [PATCH net-next 09/15] inet: move inet->transparent to inet->inet_flags
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20230810/202308102127.hRNurJL6-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.3.0
reproduce: (https://download.01.org/0day-ci/archive/20230810/202308102127.hRNurJL6-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202308102127.hRNurJL6-lkp@intel.com/
All warnings (new ones prefixed by >>):
net/mptcp/sockopt.c: In function 'mptcp_setsockopt_sol_ip_set_transparent':
>> net/mptcp/sockopt.c:689:27: warning: variable 'issk' set but not used [-Wunused-but-set-variable]
689 | struct inet_sock *issk;
| ^~~~
vim +/issk +689 net/mptcp/sockopt.c
4f6e14bd19d6de Maxim Galaganov 2021-12-03 684
c9406a23c1161c Florian Westphal 2021-11-19 685 static int mptcp_setsockopt_sol_ip_set_transparent(struct mptcp_sock *msk, int optname,
c9406a23c1161c Florian Westphal 2021-11-19 686 sockptr_t optval, unsigned int optlen)
c9406a23c1161c Florian Westphal 2021-11-19 687 {
c9406a23c1161c Florian Westphal 2021-11-19 688 struct sock *sk = (struct sock *)msk;
c9406a23c1161c Florian Westphal 2021-11-19 @689 struct inet_sock *issk;
c9406a23c1161c Florian Westphal 2021-11-19 690 struct socket *ssock;
c9406a23c1161c Florian Westphal 2021-11-19 691 int err;
c9406a23c1161c Florian Westphal 2021-11-19 692
c9406a23c1161c Florian Westphal 2021-11-19 693 err = ip_setsockopt(sk, SOL_IP, optname, optval, optlen);
c9406a23c1161c Florian Westphal 2021-11-19 694 if (err != 0)
c9406a23c1161c Florian Westphal 2021-11-19 695 return err;
c9406a23c1161c Florian Westphal 2021-11-19 696
c9406a23c1161c Florian Westphal 2021-11-19 697 lock_sock(sk);
c9406a23c1161c Florian Westphal 2021-11-19 698
c9406a23c1161c Florian Westphal 2021-11-19 699 ssock = __mptcp_nmpc_socket(msk);
ddb1a072f85870 Paolo Abeni 2023-04-14 700 if (IS_ERR(ssock)) {
c9406a23c1161c Florian Westphal 2021-11-19 701 release_sock(sk);
ddb1a072f85870 Paolo Abeni 2023-04-14 702 return PTR_ERR(ssock);
c9406a23c1161c Florian Westphal 2021-11-19 703 }
c9406a23c1161c Florian Westphal 2021-11-19 704
c9406a23c1161c Florian Westphal 2021-11-19 705 issk = inet_sk(ssock->sk);
c9406a23c1161c Florian Westphal 2021-11-19 706
c9406a23c1161c Florian Westphal 2021-11-19 707 switch (optname) {
c9406a23c1161c Florian Westphal 2021-11-19 708 case IP_FREEBIND:
53912fdfbaf575 Eric Dumazet 2023-08-10 709 inet_assign_bit(FREEBIND, ssock->sk,
53912fdfbaf575 Eric Dumazet 2023-08-10 710 inet_test_bit(FREEBIND, sk));
c9406a23c1161c Florian Westphal 2021-11-19 711 break;
c9406a23c1161c Florian Westphal 2021-11-19 712 case IP_TRANSPARENT:
ec4704602ed1ff Eric Dumazet 2023-08-10 713 inet_assign_bit(TRANSPARENT, ssock->sk,
ec4704602ed1ff Eric Dumazet 2023-08-10 714 inet_test_bit(TRANSPARENT, sk));
c9406a23c1161c Florian Westphal 2021-11-19 715 break;
c9406a23c1161c Florian Westphal 2021-11-19 716 default:
c9406a23c1161c Florian Westphal 2021-11-19 717 release_sock(sk);
c9406a23c1161c Florian Westphal 2021-11-19 718 WARN_ON_ONCE(1);
c9406a23c1161c Florian Westphal 2021-11-19 719 return -EOPNOTSUPP;
c9406a23c1161c Florian Westphal 2021-11-19 720 }
c9406a23c1161c Florian Westphal 2021-11-19 721
c9406a23c1161c Florian Westphal 2021-11-19 722 sockopt_seq_inc(msk);
c9406a23c1161c Florian Westphal 2021-11-19 723 release_sock(sk);
c9406a23c1161c Florian Westphal 2021-11-19 724 return 0;
c9406a23c1161c Florian Westphal 2021-11-19 725 }
c9406a23c1161c Florian Westphal 2021-11-19 726
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-08-10 14:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 10:39 [PATCH net-next 00/15] inet: socket lock and data-races avoidance Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 01/15] inet: introduce inet->inet_flags Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 02/15] inet: set/get simple options locklessly Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 03/15] inet: move inet->recverr to inet->inet_flags Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 04/15] inet: move inet->recverr_rfc4884 " Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 05/15] inet: move inet->freebind " Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 06/15] inet: move inet->hdrincl " Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 07/15] inet: move inet->mc_loop to inet->inet_frags Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 08/15] inet: move inet->mc_all " Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 09/15] inet: move inet->transparent to inet->inet_flags Eric Dumazet
2023-08-10 13:45 ` kernel test robot [this message]
2023-08-10 10:39 ` [PATCH net-next 10/15] inet: move inet->is_icsk " Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 11/15] inet: move inet->nodefrag " Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 12/15] inet: move inet->bind_address_no_port " Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 13/15] inet: move inet->defer_connect " Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 14/15] inet: implement lockless IP_TTL Eric Dumazet
2023-08-10 10:39 ` [PATCH net-next 15/15] inet: implement lockless IP_MINTTL Eric Dumazet
2023-08-11 3:43 ` [PATCH net-next 00/15] inet: socket lock and data-races avoidance Soheil Hassas Yeganeh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202308102127.hRNurJL6-lkp@intel.com \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=simon.horman@corigine.com \
--cc=soheil@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).