From: Vladimir Oltean <olteanv@gmail.com>
To: alexis.lothore@bootlin.com
Cc: "Clément Leger" <clement@clement-leger.fr>,
"Andrew Lunn" <andrew@lunn.ch>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
linux-renesas-soc@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
"Milan Stevanovic" <milan.stevanovic@se.com>,
"Jimmy Lalande" <jimmy.lalande@se.com>,
"Pascal Eberhard" <pascal.eberhard@se.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH net-next v5 3/3] net: dsa: rzn1-a5psw: add vlan support
Date: Fri, 11 Aug 2023 13:06:13 +0300 [thread overview]
Message-ID: <20230811100613.o77ei6updvbndkjm@skbuf> (raw)
In-Reply-To: <20230810093651.102509-4-alexis.lothore@bootlin.com> <20230810093651.102509-4-alexis.lothore@bootlin.com>
On Thu, Aug 10, 2023 at 11:36:51AM +0200, alexis.lothore@bootlin.com wrote:
> +static int a5psw_port_vlan_add(struct dsa_switch *ds, int port,
> + const struct switchdev_obj_port_vlan *vlan,
> + struct netlink_ext_ack *extack)
> +{
> + dev_dbg(a5psw->dev, "Add VLAN %d on port %d, %s, %s\n",
> + vid, port, tagged ? "tagged" : "untagged",
> + pvid ? "PVID" : "no PVID");
> +}
> +
> +static int a5psw_port_vlan_del(struct dsa_switch *ds, int port,
> + const struct switchdev_obj_port_vlan *vlan)
> +{
> + dev_dbg(a5psw->dev, "Removing VLAN %d on port %d\n", vid, port);
> +}
These are unnecessary, we have trace points for VLANs in net/dsa/trace.h.
next prev parent reply other threads:[~2023-08-11 10:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 9:36 [PATCH net-next v5 0/3] net: dsa: rzn1-a5psw: add support for vlan and .port_bridge_flags alexis.lothore
2023-08-10 9:36 ` [PATCH net-next v5 1/3] net: dsa: rzn1-a5psw: use a5psw_reg_rmw() to modify flooding resolution alexis.lothore
2023-08-10 9:36 ` [PATCH net-next v5 2/3] net: dsa: rzn1-a5psw: add support for .port_bridge_flags alexis.lothore
2023-08-11 10:03 ` Vladimir Oltean
2023-08-11 14:42 ` Alexis Lothoré
2023-08-17 17:35 ` Vladimir Oltean
2023-08-10 9:36 ` [PATCH net-next v5 3/3] net: dsa: rzn1-a5psw: add vlan support alexis.lothore
2023-08-11 10:06 ` Vladimir Oltean [this message]
2023-08-11 9:49 ` [PATCH net-next v5 0/3] net: dsa: rzn1-a5psw: add support for vlan and .port_bridge_flags Simon Horman
2023-08-11 11:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811100613.o77ei6updvbndkjm@skbuf \
--to=olteanv@gmail.com \
--cc=alexis.lothore@bootlin.com \
--cc=andrew@lunn.ch \
--cc=clement@clement-leger.fr \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=jimmy.lalande@se.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=milan.stevanovic@se.com \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pascal.eberhard@se.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).