From: Jakub Kicinski <kuba@kernel.org>
To: Manish Chopra <manishc@marvell.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Ariel Elior <aelior@marvell.com>, Alok Prasad <palok@marvell.com>,
Nilesh Javali <njavali@marvell.com>,
Saurav Kashyap <skashyap@marvell.com>,
"jmeneghi@redhat.com" <jmeneghi@redhat.com>,
"yuval.mintz@qlogic.com" <yuval.mintz@qlogic.com>,
Sudarsana Reddy Kalluru <skalluru@marvell.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"edumazet@google.com" <edumazet@google.com>,
"horms@kernel.org" <horms@kernel.org>,
David Miller <davem@davemloft.net>
Subject: Re: [EXT] Re: [PATCH v2 net] qede: fix firmware halt over suspend and resume
Date: Fri, 11 Aug 2023 14:45:07 -0700 [thread overview]
Message-ID: <20230811144507.5ab3fdae@kernel.org> (raw)
In-Reply-To: <BY3PR18MB4612F2621E50B2F12F2BC342AB10A@BY3PR18MB4612.namprd18.prod.outlook.com>
On Fri, 11 Aug 2023 09:31:15 +0000 Manish Chopra wrote:
> > Does the FW end up recovering? That could still be preferable to rejecting
> > suspend altogether. Reject is a big hammer, I'm a bit worried it will cause a
> > regression in stable.
>
> Yes, By adding the driver's suspend handler with explicit error returned
> to PCI subsystem prevents the system wide suspend and does not impact the
> device/FW at all. It keeps them operational as they were before.
I'm asking about recovery without this patch, not with it.
That should be evident from the text I'm replying under.
next prev parent reply other threads:[~2023-08-11 21:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 13:43 [PATCH v2 net] qede: fix firmware halt over suspend and resume Manish Chopra
2023-08-10 18:02 ` Simon Horman
2023-08-11 0:47 ` Jakub Kicinski
2023-08-11 9:31 ` [EXT] " Manish Chopra
2023-08-11 21:45 ` Jakub Kicinski [this message]
2023-08-14 10:24 ` Manish Chopra
2023-08-14 15:17 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811144507.5ab3fdae@kernel.org \
--to=kuba@kernel.org \
--cc=aelior@marvell.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jmeneghi@redhat.com \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=pabeni@redhat.com \
--cc=palok@marvell.com \
--cc=skalluru@marvell.com \
--cc=skashyap@marvell.com \
--cc=yuval.mintz@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).