From: Jakub Kicinski <kuba@kernel.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: Shay Drory <shayd@nvidia.com>,
netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
edumazet@google.com, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net v2] devlink: Delay health recover notification until devlink registered
Date: Fri, 11 Aug 2023 15:14:03 -0700 [thread overview]
Message-ID: <20230811151403.127c8755@kernel.org> (raw)
In-Reply-To: <20230811144231.0cea3205@kernel.org>
On Fri, 11 Aug 2023 14:42:31 -0700 Jakub Kicinski wrote:
> > Limiting the creation of health reporter only when instance is
> > registered does not seem like a good solution to me.
> >
> > As with any other object, we postpone the notifications only after
> > register is done, that sounds fine, doesn't it?
>
> No, it doesn't. Registering health reporters on a semi-initialized
> device is a major foot gun, we should not allow this unless really
> necessary.
FWIW I mean that the recovery may race with the init and try to access
things which aren't set up yet. Could lead to deadlocks or crashes at
worst and sprinkling of "if (!initialized) return;" at best.
All the same problems we had before reload was put under the instance
lock basically.
next prev parent reply other threads:[~2023-08-11 22:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 20:35 [PATCH net v2] devlink: Delay health recover notification until devlink registered Shay Drory
2023-08-10 17:33 ` Jakub Kicinski
2023-08-11 8:05 ` Jiri Pirko
2023-08-11 21:42 ` Jakub Kicinski
2023-08-11 22:14 ` Jakub Kicinski [this message]
2023-08-13 10:12 ` Shay Drory
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811151403.127c8755@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shayd@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).