* Re: [PATCH net] wifi: iwlwifi: mvm: add dependency for PTP clock
2023-08-12 5:29 [PATCH net] wifi: iwlwifi: mvm: add dependency for PTP clock Randy Dunlap
@ 2023-08-13 16:30 ` Simon Horman
2023-08-15 5:13 ` Richard Cochran
2023-08-15 8:47 ` Greenman, Gregory
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2023-08-13 16:30 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, Krishnanand Prabhu, Luca Coelho,
Gregory Greenman, Johannes Berg, Kalle Valo, linux-wireless,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, Richard Cochran
+ Richard Cochran
On Fri, Aug 11, 2023 at 10:29:47PM -0700, Randy Dunlap wrote:
> When the code to use the PTP HW clock was added, it didn't update
> the Kconfig entry for the PTP dependency, leading to build errors,
> so update the Kconfig entry to depend on PTP_1588_CLOCK_OPTIONAL.
>
> aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.o: in function `iwl_mvm_ptp_init':
> drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:294: undefined reference to `ptp_clock_register'
> drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:294:(.text+0xce8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_register'
> aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:301: undefined reference to `ptp_clock_index'
> drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:301:(.text+0xd18): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index'
> aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.o: in function `iwl_mvm_ptp_remove':
> drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:315: undefined reference to `ptp_clock_index'
> drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:315:(.text+0xe80): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index'
> aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:319: undefined reference to `ptp_clock_unregister'
> drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:319:(.text+0xeac): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_unregister'
>
> Fixes: 1595ecce1cf3 ("wifi: iwlwifi: mvm: add support for PTP HW clock (PHC)")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/all/202308110447.4QSJHmFH-lkp@intel.com/
> Cc: Krishnanand Prabhu <krishnanand.prabhu@intel.com>
> Cc: Luca Coelho <luciano.coelho@intel.com>
> Cc: Gregory Greenman <gregory.greenman@intel.com>
> Cc: Johannes Berg <johannes.berg@intel.com>
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: linux-wireless@vger.kernel.org
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org> # build-tested
> ---
> drivers/net/wireless/intel/iwlwifi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -66,6 +66,7 @@ config IWLMVM
> tristate "Intel Wireless WiFi MVM Firmware support"
> select WANT_DEV_COREDUMP
> depends on MAC80211
> + depends on PTP_1588_CLOCK_OPTIONAL
> help
> This is the driver that supports the MVM firmware. The list
> of the devices that use this firmware is available here:
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] wifi: iwlwifi: mvm: add dependency for PTP clock
2023-08-12 5:29 [PATCH net] wifi: iwlwifi: mvm: add dependency for PTP clock Randy Dunlap
2023-08-13 16:30 ` Simon Horman
@ 2023-08-15 5:13 ` Richard Cochran
2023-08-15 8:47 ` Greenman, Gregory
2 siblings, 0 replies; 4+ messages in thread
From: Richard Cochran @ 2023-08-15 5:13 UTC (permalink / raw)
To: Randy Dunlap
Cc: linux-kernel, kernel test robot, Krishnanand Prabhu, Luca Coelho,
Gregory Greenman, Johannes Berg, Kalle Valo, linux-wireless,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
On Fri, Aug 11, 2023 at 10:29:47PM -0700, Randy Dunlap wrote:
> When the code to use the PTP HW clock was added, it didn't update
> the Kconfig entry for the PTP dependency, leading to build errors,
> so update the Kconfig entry to depend on PTP_1588_CLOCK_OPTIONAL.
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] wifi: iwlwifi: mvm: add dependency for PTP clock
2023-08-12 5:29 [PATCH net] wifi: iwlwifi: mvm: add dependency for PTP clock Randy Dunlap
2023-08-13 16:30 ` Simon Horman
2023-08-15 5:13 ` Richard Cochran
@ 2023-08-15 8:47 ` Greenman, Gregory
2 siblings, 0 replies; 4+ messages in thread
From: Greenman, Gregory @ 2023-08-15 8:47 UTC (permalink / raw)
To: rdunlap@infradead.org, linux-kernel@vger.kernel.org
Cc: lkp, Coelho, Luciano, davem@davemloft.net, Berg, Johannes,
kvalo@kernel.org, linux-wireless@vger.kernel.org,
Prabhu, Krishnanand, kuba@kernel.org, edumazet@google.com,
pabeni@redhat.com, netdev@vger.kernel.org
On Fri, 2023-08-11 at 22:29 -0700, Randy Dunlap wrote:
> When the code to use the PTP HW clock was added, it didn't update
> the Kconfig entry for the PTP dependency, leading to build errors,
> so update the Kconfig entry to depend on PTP_1588_CLOCK_OPTIONAL.
>
> aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.o: in function `iwl_mvm_ptp_init':
> drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:294: undefined reference to `ptp_clock_register'
> drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:294:(.text+0xce8): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_register'
> aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:301: undefined reference to `ptp_clock_index'
> drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:301:(.text+0xd18): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index'
> aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.o: in function `iwl_mvm_ptp_remove':
> drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:315: undefined reference to `ptp_clock_index'
> drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:315:(.text+0xe80): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_index'
> aarch64-linux-ld: drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:319: undefined reference to `ptp_clock_unregister'
> drivers/net/wireless/intel/iwlwifi/mvm/ptp.c:319:(.text+0xeac): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `ptp_clock_unregister'
>
> Fixes: 1595ecce1cf3 ("wifi: iwlwifi: mvm: add support for PTP HW clock (PHC)")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/all/202308110447.4QSJHmFH-lkp@intel.com/
> Cc: Krishnanand Prabhu <krishnanand.prabhu@intel.com>
> Cc: Luca Coelho <luciano.coelho@intel.com>
> Cc: Gregory Greenman <gregory.greenman@intel.com>
> Cc: Johannes Berg <johannes.berg@intel.com>
> Cc: Kalle Valo <kvalo@kernel.org>
> Cc: linux-wireless@vger.kernel.org
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: netdev@vger.kernel.org
> ---
> drivers/net/wireless/intel/iwlwifi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff -- a/drivers/net/wireless/intel/iwlwifi/Kconfig b/drivers/net/wireless/intel/iwlwifi/Kconfig
> --- a/drivers/net/wireless/intel/iwlwifi/Kconfig
> +++ b/drivers/net/wireless/intel/iwlwifi/Kconfig
> @@ -66,6 +66,7 @@ config IWLMVM
> tristate "Intel Wireless WiFi MVM Firmware support"
> select WANT_DEV_COREDUMP
> depends on MAC80211
> + depends on PTP_1588_CLOCK_OPTIONAL
> help
> This is the driver that supports the MVM firmware. The list
> of the devices that use this firmware is available here:
Acked-by: Gregory Greenman <gregory.greenman@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread