From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E08D7E; Sun, 13 Aug 2023 01:53:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD7C6C433C7; Sun, 13 Aug 2023 01:53:28 +0000 (UTC) Date: Sat, 12 Aug 2023 21:53:27 -0400 From: Steven Rostedt To: Joe Perches Cc: Zheao Li , edumazet@google.com, bpf@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org, kuba@kernel.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, mhiramat@kernel.org, ncardwell@google.com, netdev@vger.kernel.org, pabeni@redhat.com Subject: Re: [PATCH v3] tracepoint: add new `tcp:tcp_ca_event` trace event Message-ID: <20230812215327.1dbd30f3@rorschach.local.home> In-Reply-To: <6bfa88099fe13b3fd4077bb3a3e55e3ae04c3b5d.camel@perches.com> References: <20230812201249.62237-1-me@manjusaka.me> <20230812205905.016106c0@rorschach.local.home> <20230812210140.117da558@rorschach.local.home> <20230812210450.53464a78@rorschach.local.home> <6bfa88099fe13b3fd4077bb3a3e55e3ae04c3b5d.camel@perches.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Sat, 12 Aug 2023 18:17:17 -0700 Joe Perches wrote: > > I forgot to say "for TRACE_EVENT() macros". This is not about what > > checkpatch says about other code. > > trace has its own code style and checkpatch needs another > parsing mechanism just for it, including the alignment to > open parenthesis test. If you have a template patch to add the parsing mechanism, I'd be happy to try to fill in the style. -- Steve