From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B4898F40 for ; Sun, 13 Aug 2023 16:10:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F43CC433C8; Sun, 13 Aug 2023 16:10:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691943013; bh=+cO6o0LYsxzL8TF6E5uNTi316ZMRjKQCtrB2zyYzwz0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hr1u3ihrSu1irP766vc2jVRgf97oTvDalqe5becC6Bpyq+nHPvBqQmfRklO5OF1be gPb42KS9GpKye5m0YwGU0RrqMuUD3PFs0qBnFi+kA17Qz9gK3qNSbU0m+GSZCJ5OLq 5U90/uukQX0tHnzfB7DRrHW7bWHXrfPga/FAn6RaWaVrJ13m+npNra0SYuW4AVJEWF bvldlNU/4d5/w5ZW+sXlX1pK17x0irInCp0oJICX/mssRJg75q+DSIgt3f4pN4V86/ xjh6k1viFmIB51FvNsnOL7c3mQa4hxKg0/b84GUo68KfbkLpn+RbFVwH4iGq5h93V0 NJyJ+eitf+6BA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yuanjun Gong , Simon Horman , "David S . Miller" , Sasha Levin , chris.snook@gmail.com, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, trix@redhat.com, pavan.chebbi@broadcom.com, mkl@pengutronix.de, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 5.10 08/25] ethernet: atheros: fix return value check in atl1c_tso_csum() Date: Sun, 13 Aug 2023 12:09:19 -0400 Message-Id: <20230813160936.1082758-8-sashal@kernel.org> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230813160936.1082758-1-sashal@kernel.org> References: <20230813160936.1082758-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.10.190 Content-Transfer-Encoding: 8bit From: Yuanjun Gong [ Upstream commit 8d01da0a1db237c44c92859ce3612df7af8d3a53 ] in atl1c_tso_csum, it should check the return value of pskb_trim(), and return an error code if an unexpected value is returned by pskb_trim(). Signed-off-by: Yuanjun Gong Reviewed-by: Simon Horman Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c index 3f65f2b370c57..2c5af0d7666aa 100644 --- a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c +++ b/drivers/net/ethernet/atheros/atl1c/atl1c_main.c @@ -1987,8 +1987,11 @@ static int atl1c_tso_csum(struct atl1c_adapter *adapter, real_len = (((unsigned char *)ip_hdr(skb) - skb->data) + ntohs(ip_hdr(skb)->tot_len)); - if (real_len < skb->len) - pskb_trim(skb, real_len); + if (real_len < skb->len) { + err = pskb_trim(skb, real_len); + if (err) + return err; + } hdr_len = (skb_transport_offset(skb) + tcp_hdrlen(skb)); if (unlikely(skb->len == hdr_len)) { -- 2.40.1