From: Leon Romanovsky <leon@kernel.org>
To: Li Zetao <lizetao1@huawei.com>
Cc: vadim.fedorenko@linux.dev, davem@davemloft.net,
edumazet@google.com, elic@nvidia.com, kuba@kernel.org,
linux-rdma@vger.kernel.org, mbloch@nvidia.com,
netdev@vger.kernel.org, pabeni@redhat.com, roid@nvidia.com,
saeedm@nvidia.com, shayd@nvidia.com, vladbu@nvidia.com,
kernel test robot <lkp@intel.com>,
Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH -next v2] net/mlx5: Devcom, only use devcom after NULL check in mlx5_devcom_send_event()
Date: Mon, 14 Aug 2023 13:11:13 +0300 [thread overview]
Message-ID: <20230814101113.GE3921@unreal> (raw)
In-Reply-To: <20230814072342.189470-1-lizetao1@huawei.com>
On Mon, Aug 14, 2023 at 03:23:42PM +0800, Li Zetao wrote:
> There is a warning reported by kernel test robot:
>
> smatch warnings:
> drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c:264
> mlx5_devcom_send_event() warn: variable dereferenced before
> IS_ERR check devcom (see line 259)
>
> The reason for the warning is that the pointer is used before check, put
> the assignment to comp after devcom check to silence the warning.
>
> Fixes: 88d162b47981 ("net/mlx5: Devcom, Infrastructure changes")
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <error27@gmail.com>
> Closes: https://lore.kernel.org/r/202308041028.AkXYDwJ6-lkp@intel.com/
> Signed-off-by: Li Zetao <lizetao1@huawei.com>
> ---
> v1 -> v2: Modify the order of variable declarations to end up with reverse x-mas tree order.
> v1: https://lore.kernel.org/all/20230804092636.91357-1-lizetao1@huawei.com/
>
> drivers/net/ethernet/mellanox/mlx5/core/lib/devcom.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
prev parent reply other threads:[~2023-08-14 10:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 9:26 [PATCH net-next] net/mlx5: Devcom, only use devcom after NULL check in mlx5_devcom_send_event() Li Zetao
2023-08-04 20:53 ` Vadim Fedorenko
2023-08-13 8:02 ` Roi Dayan
2023-08-14 7:23 ` [PATCH -next v2] " Li Zetao
2023-08-14 10:11 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814101113.GE3921@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=elic@nvidia.com \
--cc=error27@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=lkp@intel.com \
--cc=mbloch@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roid@nvidia.com \
--cc=saeedm@nvidia.com \
--cc=shayd@nvidia.com \
--cc=vadim.fedorenko@linux.dev \
--cc=vladbu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).