RE: [PATCH net-next v3 2/2] net: stmmac: Tx coe sw fallback

Jose Abreu
2023-08-16T15:46:17Z

Date: Tue, Aug 15, 2023 at 04:51:45

> From: Rohan G Thomas <rohan.g.thomas@intel.com>
> Date: Mon, Aug 14, 2023 at 15:06:37
> > > > + bool tx_q_coe_lmt;
> > >
> > > Please use a flag here instead of "tx_q_coe_lmt". This is the
> > > preferrable method now.
> > >
> > > Thanks,
> > > Jose
> >
> > Thanks Jose for the feedback. If I read that correctly, your suggestion is to
> > change " tx_q_coe_lmt" to something more readable, like "has_txcoe_limit".
> > Please correct me if I understand it wrongly.
> >
> > BR,
> > Rohan
> >
>
> Or, use int instead of bool?

No, I mean to replace it with a bit flag as it was done on https://lore.kernel.org/all/20230710090001.303225-1-brgl@bgdev.pl/.

Thanks,
Jose