From: Jakub Kicinski <kuba@kernel.org>
To: Ziwei Xiao <ziweixiao@google.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
Jeroen de Borst <jeroendb@google.com>,
Praveen Kaligineedi <pkaligineedi@google.com>,
Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net-next] gve: add header split support
Date: Mon, 14 Aug 2023 19:22:31 -0700 [thread overview]
Message-ID: <20230814192231.12e0c290@kernel.org> (raw)
In-Reply-To: <20230811223938.997986-1-ziweixiao@google.com>
On Fri, 11 Aug 2023 15:39:38 -0700 Ziwei Xiao wrote:
> - Add header-split and strict-header-split ethtool priv flags. These
> flags control header-split behavior. It can be turned on/off and it
> can be set to 'strict' which will cause the driver to drop all the
> packets that don't have a proper header split.
> - Add max-rx-buffer-size priv flag to allow user to switch the packet
> buffer size between max and default(e.g. 4K <-> 2K).
> - Add reconfigure rx rings to support the header split and
> max-rx-buffer-size enable/disable switch.
Someone on your team needs to participate upstream or you need
to get your patches reviewed from someone upstream-savvy before
posting.
Anyone participating in netdev reviews would have told you that
private flags are unlikely to fly upstream.
One part of an organization participating upstream while another
has no upstream understanding and throws code over the wall is
a common anti-pattern, and I intend to stop it.
--
pw-bot: cr
next prev parent reply other threads:[~2023-08-15 2:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 22:39 [PATCH net-next] gve: add header split support Ziwei Xiao
2023-08-15 2:22 ` Jakub Kicinski [this message]
2023-08-15 17:06 ` Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814192231.12e0c290@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=jeroendb@google.com \
--cc=netdev@vger.kernel.org \
--cc=pkaligineedi@google.com \
--cc=willemb@google.com \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).