From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Xuan Zhuo <xuanzhuo@linux.alibaba.com>,
virtualization@lists.linux-foundation.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Jesper Dangaard Brouer <hawk@kernel.org>,
John Fastabend <john.fastabend@gmail.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev()
Date: Tue, 15 Aug 2023 07:57:31 -0400 [thread overview]
Message-ID: <20230815075702-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACGkMEt5RyOy_6rTXon_7py=ZmdJD=e4dMOGpNOo3NOyahGvjg@mail.gmail.com>
On Tue, Aug 15, 2023 at 03:50:23PM +0800, Jason Wang wrote:
> On Tue, Aug 15, 2023 at 2:32 PM Xuan Zhuo <xuanzhuo@linux.alibaba.com> wrote:
> >
> >
> > Hi, Jason
> >
> > Could you skip this patch?
>
> I'm fine with either merging or dropping this.
>
> >
> > Let we review other patches firstly?
>
> I will be on vacation soon, and won't have time to do this until next week.
>
> But I spot two possible "issues":
>
> 1) the DMA metadata were stored in the headroom of the page, this
> breaks frags coalescing, we need to benchmark it's impact
> 2) pre mapped DMA addresses were not reused in the case of XDP_TX/XDP_REDIRECT
>
> I see Michael has merge this series so I'm fine to let it go first.
>
> Thanks
it's still queued for next. not too late to drop or better add
a patch on top.
> >
> > Thanks.
> >
next prev parent reply other threads:[~2023-08-15 11:58 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 12:30 [PATCH vhost v13 00/12] virtio core prepares for AF_XDP Xuan Zhuo
2023-08-10 12:30 ` [PATCH vhost v13 01/12] virtio_ring: check use_dma_api before unmap desc for indirect Xuan Zhuo
2023-08-10 12:30 ` [PATCH vhost v13 02/12] virtio_ring: put mapping error check in vring_map_one_sg Xuan Zhuo
2023-08-10 12:30 ` [PATCH vhost v13 03/12] virtio_ring: introduce virtqueue_set_dma_premapped() Xuan Zhuo
2023-08-10 12:30 ` [PATCH vhost v13 04/12] virtio_ring: support add premapped buf Xuan Zhuo
2024-06-04 16:07 ` Ilya Leoshkevich
2024-06-04 16:17 ` Alexander Potapenko
2024-06-05 16:02 ` Ilya Leoshkevich
2024-06-06 3:23 ` Xuan Zhuo
[not found] ` <CAG_fn=UsqAhH57s08+prkj2iJshhxuLznzDNft4dPXHKX9V72Q@mail.gmail.com>
2024-06-06 8:24 ` Xuan Zhuo
2024-06-06 9:49 ` Alexander Potapenko
2024-06-06 8:26 ` Alexander Potapenko
2023-08-10 12:30 ` [PATCH vhost v13 05/12] virtio_ring: introduce virtqueue_dma_dev() Xuan Zhuo
2023-08-14 3:05 ` Jason Wang
2023-08-14 8:56 ` Xuan Zhuo
2023-08-14 11:24 ` Michael S. Tsirkin
2023-08-14 11:55 ` Xuan Zhuo
2023-08-15 6:30 ` Xuan Zhuo
2023-08-15 7:50 ` Jason Wang
2023-08-15 9:27 ` Xuan Zhuo
2023-08-16 1:13 ` Jason Wang
2023-08-16 2:08 ` Xuan Zhuo
2023-08-16 2:19 ` Jason Wang
2023-08-16 2:21 ` Xuan Zhuo
2023-08-16 2:33 ` Jason Wang
2023-08-16 3:22 ` Xuan Zhuo
2023-08-15 11:57 ` Michael S. Tsirkin [this message]
2023-08-10 12:30 ` [PATCH vhost v13 06/12] virtio_ring: skip unmap for premapped Xuan Zhuo
2023-08-10 12:30 ` [PATCH vhost v13 07/12] virtio_ring: correct the expression of the description of virtqueue_resize() Xuan Zhuo
2023-08-10 12:30 ` [PATCH vhost v13 08/12] virtio_ring: separate the logic of reset/enable from virtqueue_resize Xuan Zhuo
2023-08-10 12:30 ` [PATCH vhost v13 09/12] virtio_ring: introduce virtqueue_reset() Xuan Zhuo
2023-08-10 12:30 ` [PATCH vhost v13 10/12] virtio_ring: introduce dma map api for virtqueue Xuan Zhuo
2023-08-10 12:30 ` [PATCH vhost v13 11/12] virtio_ring: introduce dma sync " Xuan Zhuo
2023-11-30 9:45 ` Michael S. Tsirkin
2023-11-30 9:49 ` Xuan Zhuo
2023-11-30 10:10 ` Michael S. Tsirkin
2023-11-30 10:15 ` Xuan Zhuo
2023-08-10 12:30 ` [PATCH vhost v13 12/12] virtio_net: merge dma operations when filling mergeable buffers Xuan Zhuo
2023-09-26 16:01 ` Michael S. Tsirkin
2023-09-27 1:50 ` Xuan Zhuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815075702-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hawk@kernel.org \
--cc=hch@infradead.org \
--cc=jasowang@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).