From: Leon Romanovsky <leon@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>,
jacob.e.keller@intel.com, horms@kernel.org,
Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com>
Subject: Re: [PATCH net-next v3 1/5] ice: remove FW logging code
Date: Tue, 15 Aug 2023 21:34:26 +0300 [thread overview]
Message-ID: <20230815183426.GT22185@unreal> (raw)
In-Reply-To: <20230815165750.2789609-2-anthony.l.nguyen@intel.com>
On Tue, Aug 15, 2023 at 09:57:46AM -0700, Tony Nguyen wrote:
> From: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
>
> The FW logging code doesn't work because there is no way to set
> cq_ena or uart_ena so remove the code. This code is the original
> (v1) way of FW logging so it should be replaced with the v2 way.
>
> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> .../net/ethernet/intel/ice/ice_adminq_cmd.h | 78 -------
> drivers/net/ethernet/intel/ice/ice_common.c | 217 ------------------
> drivers/net/ethernet/intel/ice/ice_common.h | 1 -
> drivers/net/ethernet/intel/ice/ice_main.c | 3 -
> drivers/net/ethernet/intel/ice/ice_type.h | 20 --
> 5 files changed, 319 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-08-15 18:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 16:57 [PATCH net-next v3 0/5][pull request] add v2 FW logging for ice driver Tony Nguyen
2023-08-15 16:57 ` [PATCH net-next v3 1/5] ice: remove FW logging code Tony Nguyen
2023-08-15 18:34 ` Leon Romanovsky [this message]
2023-08-15 16:57 ` [PATCH net-next v3 2/5] ice: configure FW logging Tony Nguyen
2023-08-15 18:38 ` Leon Romanovsky
2023-08-17 21:25 ` Paul M Stillwell Jr
2023-08-18 11:10 ` Leon Romanovsky
2023-08-18 12:31 ` Przemek Kitszel
2023-08-21 23:20 ` Paul M Stillwell Jr
2023-08-22 7:33 ` Przemek Kitszel
2023-08-22 20:44 ` Keller, Jacob E
2023-08-22 20:58 ` Paul M Stillwell Jr
2023-08-22 21:16 ` Paul M Stillwell Jr
2023-08-22 20:45 ` Keller, Jacob E
2023-08-22 20:59 ` Paul M Stillwell Jr
2023-08-23 22:23 ` Paul M Stillwell Jr
2023-08-15 16:57 ` [PATCH net-next v3 3/5] ice: enable " Tony Nguyen
2023-08-15 16:57 ` [PATCH net-next v3 4/5] ice: add ability to read FW log data and configure the number of log buffers Tony Nguyen
2023-08-15 16:57 ` [PATCH net-next v3 5/5] ice: add documentation for FW logging Tony Nguyen
2023-08-16 22:43 ` Randy Dunlap
2023-08-23 22:25 ` Paul M Stillwell Jr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230815183426.GT22185@unreal \
--to=leon@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=himasekharx.reddy.pucha@intel.com \
--cc=horms@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=paul.m.stillwell.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).