From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B735614276 for ; Tue, 15 Aug 2023 18:34:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65444C433C7; Tue, 15 Aug 2023 18:34:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692124471; bh=zMC6PsjUY3Yq7OJqlmuW8VvAtLE3VXwPHaS/2IG7fF0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NbCVnCQHd4Ol7D5gUzgfD38w3NXS6NxA1sxpFEJZqY/UDp3BtlLog7cBLVPFxDw7d eN5dFKQWbDvLzaCXeQ+jmIhr5VYWR8XQMg2iE4qTnl0UmTR+S6dsHlTq2WZUJaD+gq 7Bws6aVH9HAK0XQ5uFOvrOFmC4e8ejnq0nkTwwKcWdH309kaiV864MwPPFLErjnzeg fxIwVaBuagoOuBwAhozuXA6ktaQqqoO+Llc94jJUCsnHuKbnqIBK9Rou31hTmrCfU3 ty+18QFNFjQ5z+UpboLnyHeGqNsPkE0DxfuPFpOsmf6ydSuq0KtV0IYqMDjMvSy4y2 R7ZYNDYxyq63A== Date: Tue, 15 Aug 2023 21:34:26 +0300 From: Leon Romanovsky To: Tony Nguyen Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, Paul M Stillwell Jr , jacob.e.keller@intel.com, horms@kernel.org, Pucha Himasekhar Reddy Subject: Re: [PATCH net-next v3 1/5] ice: remove FW logging code Message-ID: <20230815183426.GT22185@unreal> References: <20230815165750.2789609-1-anthony.l.nguyen@intel.com> <20230815165750.2789609-2-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230815165750.2789609-2-anthony.l.nguyen@intel.com> On Tue, Aug 15, 2023 at 09:57:46AM -0700, Tony Nguyen wrote: > From: Paul M Stillwell Jr > > The FW logging code doesn't work because there is no way to set > cq_ena or uart_ena so remove the code. This code is the original > (v1) way of FW logging so it should be replaced with the v2 way. > > Signed-off-by: Paul M Stillwell Jr > Tested-by: Pucha Himasekhar Reddy (A Contingent worker at Intel) > Signed-off-by: Tony Nguyen > --- > .../net/ethernet/intel/ice/ice_adminq_cmd.h | 78 ------- > drivers/net/ethernet/intel/ice/ice_common.c | 217 ------------------ > drivers/net/ethernet/intel/ice/ice_common.h | 1 - > drivers/net/ethernet/intel/ice/ice_main.c | 3 - > drivers/net/ethernet/intel/ice/ice_type.h | 20 -- > 5 files changed, 319 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky