From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9357210957 for ; Wed, 16 Aug 2023 15:29:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9068EC433C8; Wed, 16 Aug 2023 15:29:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692199750; bh=K3pspvi+mNztq0zUKx2QOh+ZhXb8RA04MXtTRCHzTlk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=L4jvAo9Le55BA3M8kyRi3pLpFgETZBGFwqYsjeJJy95vCY7nZz4V9MEGhcTQLe9QC U6IcqoiOj5syiLeJtst1wJMMAhvh6KLZwXc3Ta6goTfXMUxTsh5ua/zsTgyTnNB5eG B8+FK5cdEUqx/3okhEbc+y1wnXJLPBE++iT74ErxWjTkbVV8AOrRNs5Q4AH4eN2pIe F/gzVXunyKORmmi8M0Dv/od19L0+ZdkHAfqZhsk3cncAZSZjhLV4ZYJ+syKf089gLR yArITDJlAHC4kmfhhqb6i5jJHfVJQTw30II8cRyg+lP5DG7PQwWO/xkhgc7MOLTQMl 3muPgzzpFALMg== Date: Wed, 16 Aug 2023 08:29:08 -0700 From: Jakub Kicinski To: Donald Hunter Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , linux-doc@vger.kernel.org, Stanislav Fomichev , Arkadiusz Kubalewski , donald.hunter@redhat.com Subject: Re: [PATCH net-next v2 06/10] tools/net/ynl: Add support for netlink-raw families Message-ID: <20230816082908.1365f287@kernel.org> In-Reply-To: <20230815194254.89570-7-donald.hunter@gmail.com> References: <20230815194254.89570-1-donald.hunter@gmail.com> <20230815194254.89570-7-donald.hunter@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 15 Aug 2023 20:42:50 +0100 Donald Hunter wrote: > Refactor the ynl code to encapsulate protocol specifics into > NetlinkProtocol and GenlProtocol. Looks good, but do we also need some extra plumbing to decode extack for classic netlink correctly? Basically shouldn't _decode_extack() also move to proto? Or we can parameterize it? All we really need there is to teach it how much of fixed headers parser needs to skip to get to attributes, really (which, BTW is already kinda buggy for genl families with fixed headers).