From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE3AA1079B for ; Wed, 16 Aug 2023 14:32:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9F59FC433C7; Wed, 16 Aug 2023 14:32:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692196374; bh=yz3mExc/Khw1bsByECExMmkjKVdaFcBkmberfyUhEi8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pP60Lj0c3VxgEMvc1mPT6UhQR9MIJCwdiXXKZNUCUU+vSQvS/yIngU4xFbO6q5ULG 1KMZEMLQGCTVTClpxcoyt3isxBH7+JmVpEpL4smmSegpYidqxn1RS+L7cc2V3bZF8o EtzbbxSDLqyPk2aBdvzPcJoNE69J1Udyzj0sEwQli+Fnlb+u6hR1E9VRRm52hhm+bS PWGEeyso7vKauNDoRgOPhRH9U3pfjk0WAkWS1ohYaAaifA1oceKiMEl8ogAtatNu9Z fgbKa72sW0NduqFGqtcOEeQ+MKdj3MLI7911/fEVYyp5dblDLfm9/AP7HUwFKQ7KI9 ay//1UKCXbIgQ== Date: Wed, 16 Aug 2023 17:32:50 +0300 From: Leon Romanovsky To: Ruan Jinjie Cc: netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: Re: [PATCH -next] net: dm9051: Use PTR_ERR_OR_ZERO() to simplify code Message-ID: <20230816143250.GY22185@unreal> References: <20230816090722.2308686-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230816090722.2308686-1-ruanjinjie@huawei.com> On Wed, Aug 16, 2023 at 05:07:22PM +0800, Ruan Jinjie wrote: > Return PTR_ERR_OR_ZERO() instead of return 0 or PTR_ERR() to > simplify code. > > Signed-off-by: Ruan Jinjie > --- > drivers/net/ethernet/davicom/dm9051.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Patch subject needs to be [PATCH net-next] .... Thanks, Reviewed-by: Leon Romanovsky