From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 08C3D1AA86 for ; Wed, 16 Aug 2023 20:54:36 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 16828E69 for ; Wed, 16 Aug 2023 13:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692219275; x=1723755275; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=qWCRKGCCpp/k8uGcyLQKx/yalaTysjD3VEs14ySAJ08=; b=Ie/5SxNRMn4HPFjT+MjLtGvU+Ist7bNmN7mZ3Dt/0XKNJStnmIGYaliw n+GcxZrZMQoptfZ/xWuDcaU3vztIHrEoQV9oKWAs6cfuCOvdKs7Q6gQXB GNlWV6loJDsrR4jomi/ugsh+e06/vxbpJ40znJJqcBN7A6NUXi7yejmoc vtLqPpsB3ja2As6aI283Ie14sqS7D1p4xzQ7gDY9tfMMboc7vpxa67s8o ZToRUJfoZvvaeWDesZr9lArMURsJLJP7acSGWGZ+7/4zuWnbzqwDk7ZTj FQSk7tDJGpkOeSwIjuPvNO/8o9YbGJeO0hPBKONO1Ecj4XvrSSmJiKDRD w==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="357604788" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="357604788" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2023 13:54:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="848626394" X-IronPort-AV: E=Sophos;i="6.01,178,1684825200"; d="scan'208";a="848626394" Received: from anguy11-upstream.jf.intel.com ([10.166.9.133]) by fmsmga002.fm.intel.com with ESMTP; 16 Aug 2023 13:54:32 -0700 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org Cc: Jan Sokolowski , anthony.l.nguyen@intel.com, Jacob Keller , Przemek Kitszel Subject: [PATCH net-next 07/14] ice: refactor ice_vsi_is_vlan_pruning_ena Date: Wed, 16 Aug 2023 13:47:29 -0700 Message-Id: <20230816204736.1325132-8-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230816204736.1325132-1-anthony.l.nguyen@intel.com> References: <20230816204736.1325132-1-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net From: Jan Sokolowski As this method became static, and is already called with check for vsi being non-null, an unnecessary check along with superfluous parentheses is removed. Signed-off-by: Jan Sokolowski Reviewed-by: Jacob Keller Reviewed-by: Przemek Kitszel Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_lib.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c index d3fb2b7535e7..201570cd2e0b 100644 --- a/drivers/net/ethernet/intel/ice/ice_lib.c +++ b/drivers/net/ethernet/intel/ice/ice_lib.c @@ -1235,10 +1235,7 @@ ice_chnl_vsi_setup_q_map(struct ice_vsi *vsi, struct ice_vsi_ctx *ctxt) */ static bool ice_vsi_is_vlan_pruning_ena(struct ice_vsi *vsi) { - if (!vsi) - return false; - - return (vsi->info.sw_flags2 & ICE_AQ_VSI_SW_FLAG_RX_VLAN_PRUNE_ENA); + return vsi->info.sw_flags2 & ICE_AQ_VSI_SW_FLAG_RX_VLAN_PRUNE_ENA; } /** -- 2.38.1