From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A4B813AD7 for ; Thu, 17 Aug 2023 14:54:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E9331C433C9; Thu, 17 Aug 2023 14:54:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692284052; bh=AOOfVg3e/s3+25cWM9lAvk/yXFSa41SxrSYIyPfpKsk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QONEdwsnLM4PXR3bR+xS8DLGGKgA7FynsruyB0XiC7/1c/s9XEsYLfzu1X8TzCbNw mXQONNYTId8rBay+2R3kWHTDRneI2XRZLFOV9TjkYEW31r9096XZyJkociObSomsJZ 2zhCTUZapAMLXZRdigseJzQEQQY6pJHzmDGHHmiHNIxcVXlEpm/IhB2WqsHzNAWNXN u4PNAedFOjOxgpx5p2yr2Kuj9sCIfhNYllkyn/6HFmOdhm1RNJzRY1V39X+xIuEvrC AKqoiyIdcc9cd53kpB/3BnE4DiNPbVTxDXI/jN8l37/tiWiwG34eJOfm5ZCNPpW0zd Z2sRcSe3S4YAg== Received: (nullmailer pid 958974 invoked by uid 1000); Thu, 17 Aug 2023 14:54:08 -0000 Date: Thu, 17 Aug 2023 09:54:08 -0500 From: Rob Herring To: Sriranjani P Cc: edumazet@google.com, linux-kernel@vger.kernel.org, alexandre.torgue@foss.st.com, ravi.patel@samsung.com, alim.akhtar@samsung.com, linux-samsung-soc@vger.kernel.org, linux-fsd@tesla.com, conor+dt@kernel.org, mcoquelin.stm32@gmail.com, kuba@kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, pabeni@redhat.com, pankaj.dubey@samsung.com, richardcochran@gmail.com, krzysztof.kozlowski+dt@linaro.org, joabreu@synopsys.com, devicetree@vger.kernel.org, davem@davemloft.net, swathi.ks@samsung.com Subject: Re: [PATCH v3 1/4] dt-bindings: net: Add FSD EQoS device tree bindings Message-ID: <20230817145408.GA953517-robh@kernel.org> References: <20230814112539.70453-1-sriranjani.p@samsung.com> <20230814112539.70453-2-sriranjani.p@samsung.com> <169201998303.2086680.8457687937999615543.robh@kernel.org> <000001d9d003$b3a9a8a0$1afcf9e0$@samsung.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000001d9d003$b3a9a8a0$1afcf9e0$@samsung.com> On Wed, Aug 16, 2023 at 11:06:51AM +0530, Sriranjani P wrote: > > > > -----Original Message----- > > From: Rob Herring [mailto:robh@kernel.org] > > Sent: 14 August 2023 19:03 > > To: Sriranjani P > > Cc: edumazet@google.com; linux-kernel@vger.kernel.org; > > alexandre.torgue@foss.st.com; ravi.patel@samsung.com; > > alim.akhtar@samsung.com; linux-samsung-soc@vger.kernel.org; linux- > > fsd@tesla.com; conor+dt@kernel.org; mcoquelin.stm32@gmail.com; > > kuba@kernel.org; netdev@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; pabeni@redhat.com; robh+dt@kernel.org; > > pankaj.dubey@samsung.com; richardcochran@gmail.com; > > krzysztof.kozlowski+dt@linaro.org; joabreu@synopsys.com; > > devicetree@vger.kernel.org; davem@davemloft.net; > > swathi.ks@samsung.com > > Subject: Re: [PATCH v3 1/4] dt-bindings: net: Add FSD EQoS device tree > > bindings > > > > > > On Mon, 14 Aug 2023 16:55:36 +0530, Sriranjani P wrote: > > > Add FSD Ethernet compatible in Synopsys dt-bindings document. Add FSD > > > Ethernet YAML schema to enable the DT validation. > > > > > > Signed-off-by: Pankaj Dubey > > > Signed-off-by: Ravi Patel > > > Signed-off-by: Swathi K S > > > Signed-off-by: Sriranjani P > > > --- > > > .../devicetree/bindings/net/snps,dwmac.yaml | 5 +- > > > .../devicetree/bindings/net/tesla,ethqos.yaml | 114 > > > ++++++++++++++++++ > > > 2 files changed, 117 insertions(+), 2 deletions(-) create mode > > > 100644 Documentation/devicetree/bindings/net/tesla,ethqos.yaml > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m > > dt_binding_check' > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > yamllint warnings/errors: > > > > dtschema/dtc warnings/errors: > > /builds/robherring/dt-review- > > ci/linux/Documentation/devicetree/bindings/net/tesla,ethqos.yaml: > > properties:clock-names: {'minItems': 5, 'maxItems': 10, 'items': [{'const': > > 'ptp_ref'}, {'const': 'master_bus'}, {'const': 'slave_bus'}, {'const': 'tx'}, {'const': > > 'rx'}, {'const': 'master2_bus'}, {'const': 'slave2_bus'}, {'const': > > 'eqos_rxclk_mux'}, {'const': 'eqos_phyrxclk'}, {'const': > > 'dout_peric_rgmii_clk'}]} should not be valid under {'required': ['maxItems']} > > hint: "maxItems" is not needed with an "items" list > > from schema $id: https://protect2.fireeye.com/v1/url?k=f50e335d- > > aa950a44-f50fb812-000babff3793-de26ea17ef025418&q=1&e=897786e4- > > 5f9b-40d8-8a7f-399cb69c7ee8&u=http%3A%2F%2Fdevicetree.org%2Fmeta- > > schemas%2Fitems.yaml%23 > > Documentation/devicetree/bindings/net/tesla,ethqos.example.dtb: > > /example-0/ethernet@14300000: failed to match any schema with > > compatible: ['tesla,dwc-qos-ethernet-4.21'] > > > > Thanks for review. Will fix this in v4. It's not a review. It's an automated reply running what you should have run yourself... > > > doc reference errors (make refcheckdocs): > > > > See https://protect2.fireeye.com/v1/url?k=ccb7f6d0-932ccfc9-ccb67d9f- > > 000babff3793-2137ac63fe6ddef8&q=1&e=897786e4-5f9b-40d8-8a7f- > > 399cb69c7ee8&u=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fdev > > icetree-bindings%2Fpatch%2F20230814112539.70453-2- > > sriranjani.p%40samsung.com > > > > The base for the series is generally the latest rc1. A different dependency > > should be noted in *this* patch. > > > > Sorry, I could not get this comment, can you elaborate this. The automated tests apply patches to the latest rc1 tag. Patches which apply, but have some other dependency may have warnings. If you have such a dependency, you should note it in the patch (below the '---'). Rob