From: Leon Romanovsky <leon@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Jan Sokolowski <jan.sokolowski@intel.com>,
Jacob Keller <jacob.e.keller@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>
Subject: Re: [PATCH net-next 07/14] ice: refactor ice_vsi_is_vlan_pruning_ena
Date: Thu, 17 Aug 2023 20:08:54 +0300 [thread overview]
Message-ID: <20230817170854.GQ22185@unreal> (raw)
In-Reply-To: <20230816204736.1325132-8-anthony.l.nguyen@intel.com>
On Wed, Aug 16, 2023 at 01:47:29PM -0700, Tony Nguyen wrote:
> From: Jan Sokolowski <jan.sokolowski@intel.com>
>
> As this method became static, and is already called
> with check for vsi being non-null, an unnecessary check along
> with superfluous parentheses is removed.
>
> Signed-off-by: Jan Sokolowski <jan.sokolowski@intel.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice_lib.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-08-17 17:08 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 20:47 [PATCH net-next 00/14][pull request] Intel Wired LAN Driver Updates 2023-08-16 (ice) Tony Nguyen
2023-08-16 20:47 ` [PATCH net-next 01/14] ice: remove unused methods Tony Nguyen
2023-08-17 11:29 ` Leon Romanovsky
2023-08-16 20:47 ` [PATCH net-next 02/14] ice: refactor ice_ddp to make functions static Tony Nguyen
2023-08-17 11:30 ` Leon Romanovsky
2023-08-16 20:47 ` [PATCH net-next 03/14] ice: refactor ice_lib " Tony Nguyen
2023-08-17 11:30 ` Leon Romanovsky
2023-08-16 20:47 ` [PATCH net-next 04/14] ice: refactor ice_vf_lib " Tony Nguyen
2023-08-17 11:34 ` Leon Romanovsky
2023-08-17 21:04 ` Tony Nguyen
2023-08-16 20:47 ` [PATCH net-next 05/14] ice: refactor ice_sched " Tony Nguyen
2023-08-17 11:34 ` Leon Romanovsky
2023-08-16 20:47 ` [PATCH net-next 06/14] ice: refactor ice_ptp_hw " Tony Nguyen
2023-08-17 11:37 ` Leon Romanovsky
2023-08-16 20:47 ` [PATCH net-next 07/14] ice: refactor ice_vsi_is_vlan_pruning_ena Tony Nguyen
2023-08-17 17:08 ` Leon Romanovsky [this message]
2023-08-16 20:47 ` [PATCH net-next 08/14] ice: move E810T functions to before device agnostic ones Tony Nguyen
2023-08-17 17:09 ` Leon Romanovsky
2023-08-16 20:47 ` [PATCH net-next 09/14] ice: Remove redundant VSI configuration in eswitch setup Tony Nguyen
2023-08-17 17:09 ` Leon Romanovsky
2023-08-16 20:47 ` [PATCH net-next 10/14] ice: use list_for_each_entry() helper Tony Nguyen
2023-08-17 17:09 ` Leon Romanovsky
2023-08-16 20:47 ` [PATCH net-next 11/14] ice: drop two params from ice_aq_alloc_free_res() Tony Nguyen
2023-08-17 17:10 ` Leon Romanovsky
2023-08-16 20:47 ` [PATCH net-next 12/14] ice: ice_aq_check_events: fix off-by-one check when filling buffer Tony Nguyen
2023-08-16 20:47 ` [PATCH net-next 13/14] ice: embed &ice_rq_event_info event into struct ice_aq_task Tony Nguyen
2023-08-17 17:10 ` Leon Romanovsky
2023-08-16 20:47 ` [PATCH net-next 14/14] ice: split ice_aq_wait_for_event() func into two Tony Nguyen
2023-08-17 17:11 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817170854.GQ22185@unreal \
--to=leon@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=jan.sokolowski@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).