From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 88BF114F65 for ; Thu, 17 Aug 2023 17:08:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2BDEFC433C7; Thu, 17 Aug 2023 17:08:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692292139; bh=ilXzsVJKdtYRUHLDwj6TNqhA9YxLtUSEu1TjUvRWNKA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FCMGHzTOHPVHUl1atkAAXeHmPB2MhtN7fFBT3XLeUYiXEDrlrSj80fH2Tr5ha/uzK GeE2SWsegYHGnZVShvKv1HDZJQTv3/hjNpOIxqmrL7dLwTUAmbxVmuRNPIPrd74SnC smvXkYQaian4gfnKVL5JRj7XS+G/gSI3zt+rS+3bLfIJ5Zp5YSXS+Qc9Fhh+Zc8Zln ZRwYWNlpBEELZ/hKKAtLD4K6qwxOVmEmKGCwVffZ8kOGZmWYAHbOeBsNILlysEfbb6 GtN9eYml/dn149NGJDZfx+iXzqya6MRU0G2FW+V+5HzaL8Ef6dU8cpxVzopOBw/vGf rhF1lv2vusNEA== Date: Thu, 17 Aug 2023 20:08:54 +0300 From: Leon Romanovsky To: Tony Nguyen Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org, Jan Sokolowski , Jacob Keller , Przemek Kitszel Subject: Re: [PATCH net-next 07/14] ice: refactor ice_vsi_is_vlan_pruning_ena Message-ID: <20230817170854.GQ22185@unreal> References: <20230816204736.1325132-1-anthony.l.nguyen@intel.com> <20230816204736.1325132-8-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230816204736.1325132-8-anthony.l.nguyen@intel.com> On Wed, Aug 16, 2023 at 01:47:29PM -0700, Tony Nguyen wrote: > From: Jan Sokolowski > > As this method became static, and is already called > with check for vsi being non-null, an unnecessary check along > with superfluous parentheses is removed. > > Signed-off-by: Jan Sokolowski > Reviewed-by: Jacob Keller > Reviewed-by: Przemek Kitszel > Signed-off-by: Tony Nguyen > --- > drivers/net/ethernet/intel/ice/ice_lib.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > Thanks, Reviewed-by: Leon Romanovsky