From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B143C360 for ; Fri, 18 Aug 2023 00:13:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E10CAC433C8; Fri, 18 Aug 2023 00:13:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692317585; bh=C+/ynu2hvYBZtMBA0r4hOOlLWuECvWqT7CdHlGYSyOg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=W8vzdhF1m8OKXIxoynFZYEQ7ilo4PsVUGeH/Ttgdoz9gEspboET+K+uLqbEtqepN9 UPmbglsiNgieILiXJz7A4CMIvEXeTjtoOBlafwGgp+H6Esoa1tF5dsKVFg4trwaKJR uxFH6OL7HPfAYxW4YUf8dcF5oaxtFD+zeK8gfagJ5yDVEogJbiLF9Nkjc4R6Y2VsvA gQltnN5Pv061UpTTKiE7fvsjKTZusHScorNhA6DCyvnSu1QolXtyAIWX2v9r9XxilN YX1/+3MqGMxZI9x6WyibwCZYlRwWrvD1ex2FGeV98vncthTiaAtSsvXRFGiNTbvakJ w6OFs2oOnqsWA== Date: Thu, 17 Aug 2023 17:13:03 -0700 From: Jakub Kicinski To: Mina Almasry Cc: netdev@vger.kernel.org, hawk@kernel.org, ilias.apalodimas@linaro.org, aleksander.lobakin@intel.com, linyunsheng@huawei.com, Willem de Bruijn , Praveen Kaligineedi Subject: Re: [RFC net-next 00/13] net: page_pool: add netlink-based introspection Message-ID: <20230817171303.32c56797@kernel.org> In-Reply-To: References: <20230816234303.3786178-1-kuba@kernel.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 17 Aug 2023 14:21:26 -0700 Mina Almasry wrote: > - rx-queue GET API fits in nicely with what you described yesterday > [1]. At the moment I'm a bit unsure because the SET api you described > yesterday sounded per-rx-queue to me. But the GET api here is > per-page-pool based. Maybe the distinction doesn't matter? Maybe > you're thinking they're unrelated APIs? Right, they aren't unrelated but I do somehow prefer the more flexible model where each object type has its own API and the objects can refer to each other. I think there's too much of a risk that the mapping between page pools to queues will become n:m and then having them tied together will be a problem.