From: Jakub Kicinski <kuba@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
netdev@vger.kernel.org,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Naama Meir <naamax.meir@linux.intel.com>,
Sasha Neftin <sasha.neftin@intel.com>,
Simon Horman <simon.horman@corigine.com>,
Leon Romanovsky <leonro@nvidia.com>
Subject: Re: [PATCH net-next v2] e1000e: Use PME poll to circumvent unreliable ACPI wake
Date: Thu, 17 Aug 2023 19:18:25 -0700 [thread overview]
Message-ID: <20230817191825.18711c80@kernel.org> (raw)
In-Reply-To: <20230815170111.2789869-1-anthony.l.nguyen@intel.com>
On Tue, 15 Aug 2023 10:01:11 -0700 Tony Nguyen wrote:
> From: Kai-Heng Feng <kai.heng.feng@canonical.com>
>
> On some I219 devices, ethernet cable plugging detection only works once
> from PCI D3 state. Subsequent cable plugging does set PME bit correctly,
> but device still doesn't get woken up.
>
> Since I219 connects to the root complex directly, it relies on platform
> firmware (ACPI) to wake it up. In this case, the GPE from _PRW only
> works for first cable plugging but fails to notify the driver for
> subsequent plugging events.
>
> The issue was originally found on CNP, but the same issue can be found
> on ADL too. So workaround the issue by continuing use PME poll after
> first ACPI wake. As PME poll is always used, the runtime suspend
> restriction for CNP can also be removed.
Applied, thanks!
I'm curious - why not treat it as a fix?
next prev parent reply other threads:[~2023-08-18 2:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-15 17:01 [PATCH net-next v2] e1000e: Use PME poll to circumvent unreliable ACPI wake Tony Nguyen
2023-08-18 2:18 ` Jakub Kicinski [this message]
2023-08-18 16:31 ` Tony Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817191825.18711c80@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kai.heng.feng@canonical.com \
--cc=leonro@nvidia.com \
--cc=naamax.meir@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sasha.neftin@intel.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).