From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E95B31D308 for ; Thu, 17 Aug 2023 21:29:40 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F3CC6E4F for ; Thu, 17 Aug 2023 14:29:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692307780; x=1723843780; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=vqZnPCweTzl3DZaa9x6LLYk45/LnwSmleyyLBF3dd8g=; b=S7iWVlHRnrJE2K0bbpbn7mbVd9VYaojbvLt6iGWMkI9mGvTpKA2ZW5+n VlFulLWEYn/irBVchyGNOvqN1GZ5B1FQVS4VAlzK2nT0nH/NC3Gfev8vb RuCrq1MXCt/OGnSS630Mu5exgV6n6ozSdfJCVN83WfKiuqFq1PzMmvh5s iBwRFn3H4okEqAFvHjfQMmnWxCx2yIsvRWA+3iBkpgqZE7YRKzcRjF49L eoo+ID/nLD5QkPakll/FftPCpRbdaLpH9kvIgK9F/JBzURtUeDFlX/xxX 6eDBkFLgVrBauKDzGez9sFOq/kWHhVcRMdjvzMrwvD3GF3AzoVV9qQQzi A==; X-IronPort-AV: E=McAfee;i="6600,9927,10805"; a="363095083" X-IronPort-AV: E=Sophos;i="6.01,181,1684825200"; d="scan'208";a="363095083" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2023 14:29:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10805"; a="824813721" X-IronPort-AV: E=Sophos;i="6.01,181,1684825200"; d="scan'208";a="824813721" Received: from anguy11-upstream.jf.intel.com ([10.166.9.133]) by FMSMGA003.fm.intel.com with ESMTP; 17 Aug 2023 14:29:37 -0700 From: Tony Nguyen To: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, netdev@vger.kernel.org Cc: Jan Sokolowski , anthony.l.nguyen@intel.com, Jacob Keller , Przemek Kitszel , Leon Romanovsky Subject: [PATCH net-next v2 08/15] ice: refactor ice_vsi_is_vlan_pruning_ena Date: Thu, 17 Aug 2023 14:22:32 -0700 Message-Id: <20230817212239.2601543-9-anthony.l.nguyen@intel.com> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20230817212239.2601543-1-anthony.l.nguyen@intel.com> References: <20230817212239.2601543-1-anthony.l.nguyen@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net From: Jan Sokolowski As this method became static, and is already called with check for vsi being non-null, an unnecessary check along with superfluous parentheses is removed. Signed-off-by: Jan Sokolowski Reviewed-by: Jacob Keller Reviewed-by: Przemek Kitszel Reviewed-by: Leon Romanovsky Signed-off-by: Tony Nguyen --- drivers/net/ethernet/intel/ice/ice_lib.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/ethernet/intel/ice/ice_lib.c b/drivers/net/ethernet/intel/ice/ice_lib.c index d3fb2b7535e7..201570cd2e0b 100644 --- a/drivers/net/ethernet/intel/ice/ice_lib.c +++ b/drivers/net/ethernet/intel/ice/ice_lib.c @@ -1235,10 +1235,7 @@ ice_chnl_vsi_setup_q_map(struct ice_vsi *vsi, struct ice_vsi_ctx *ctxt) */ static bool ice_vsi_is_vlan_pruning_ena(struct ice_vsi *vsi) { - if (!vsi) - return false; - - return (vsi->info.sw_flags2 & ICE_AQ_VSI_SW_FLAG_RX_VLAN_PRUNE_ENA); + return vsi->info.sw_flags2 & ICE_AQ_VSI_SW_FLAG_RX_VLAN_PRUNE_ENA; } /** -- 2.38.1