From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
Cong Wang <xiyou.wangcong@gmail.com>,
Pedro Tammela <pctammela@mojatatu.com>,
Victor Nogueira <victor@mojatatu.com>,
syzbot <syzbot+a3618a167af2021433cd@syzkaller.appspotmail.com>,
bpf@vger.kernel.org, brauner@kernel.org, davem@davemloft.net,
edumazet@google.com, jiri@nvidia.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, syzkaller-bugs@googlegroups.com,
Vinicius Costa Gomes <vinicius.gomes@intel.com>
Subject: Re: [syzbot] [net?] INFO: rcu detected stall in unix_release
Date: Fri, 18 Aug 2023 19:07:11 +0300 [thread overview]
Message-ID: <20230818160711.k7irnjba3qxx3rfu@skbuf> (raw)
In-Reply-To: <CAM0EoMk5USiuZ84JeJQYCDQQ5dV-jiuGRVVocqH2izi7xcZnkg@mail.gmail.com>
Hi Jamal,
On Fri, Aug 18, 2023 at 11:27:27AM -0400, Jamal Hadi Salim wrote:
> Can you try the attached patchlet?
Thanks for the patch. I've tried it, and it eliminates the code path
(and thus the problem) exposed by the syzbot program, by responding to
RTM_NEWQDISC messages having the NLM_F_CREATE|NLM_F_REPLACE|NLM_F_EXCL
flags with "Error: Exclusivity flag on, cannot modify.".
Actually, to be precise, the first such netlink message successfully
creates the qdisc, but then the subsequent ones leave that qdisc alone
(don't change it), by failing with this extack message.
If that's the behavior that you intended, then I guess the answer is
that it works. Thanks a lot.
What would be an appropriate Fixes: tag?
Side note: I believe that we can now also revert commit be3618d96510
("net/sched: taprio: fix slab-out-of-bounds Read in taprio_dequeue_from_txq"),
which was papering over an unknown (at the time) issue - the same as
this one - without really even completely covering it, either. Hence
this other syzbot report.
https://lore.kernel.org/netdev/3b977f76-0289-270e-8310-179315ee927d@huawei.com/T/
https://lore.kernel.org/netdev/20230608062756.3626573-1-shaozhengchao@huawei.com/
next prev parent reply other threads:[~2023-08-18 16:07 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-13 20:45 [syzbot] [net?] INFO: rcu detected stall in unix_release syzbot
2023-08-14 23:03 ` Jakub Kicinski
2023-08-15 11:28 ` Vladimir Oltean
2023-08-16 22:57 ` Vladimir Oltean
2023-08-17 2:58 ` Jakub Kicinski
2023-08-17 16:30 ` Jamal Hadi Salim
2023-08-18 15:27 ` Jamal Hadi Salim
2023-08-18 16:07 ` Vladimir Oltean [this message]
2023-08-18 17:10 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818160711.k7irnjba3qxx3rfu@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=bpf@vger.kernel.org \
--cc=brauner@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jhs@mojatatu.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pctammela@mojatatu.com \
--cc=syzbot+a3618a167af2021433cd@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=victor@mojatatu.com \
--cc=vinicius.gomes@intel.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).