netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Cc: Tony Nguyen <anthony.l.nguyen@intel.com>, <davem@davemloft.net>,
	<pabeni@redhat.com>, <edumazet@google.com>,
	<netdev@vger.kernel.org>, Alan Brady <alan.brady@intel.com>,
	<pavan.kumar.linga@intel.com>, <emil.s.tantilov@intel.com>,
	<jesse.brandeburg@intel.com>, <sridhar.samudrala@intel.com>,
	<shiraz.saleem@intel.com>, <sindhu.devale@intel.com>,
	<willemb@google.com>, <decot@google.com>, <andrew@lunn.ch>,
	<leon@kernel.org>, <mst@redhat.com>, <simon.horman@corigine.com>,
	<shannon.nelson@amd.com>, <stephen@networkplumber.org>,
	Alice Michael <alice.michael@intel.com>,
	"Joshua Hay" <joshua.a.hay@intel.com>,
	Phani Burra <phani.r.burra@intel.com>
Subject: Re: [PATCH net-next v5 14/15] idpf: add ethtool callbacks
Date: Fri, 18 Aug 2023 17:01:21 -0700	[thread overview]
Message-ID: <20230818170121.3112bb0a@kernel.org> (raw)
In-Reply-To: <53a996f1-402e-dea8-9c08-51b84d02d0ac@intel.com>

On Sat, 19 Aug 2023 00:42:56 +0200 Przemek Kitszel wrote:
> I see that here we (Intel) attempt for the first time to propose our 
> "Unified stats" naming scheme [1].
> 
> Purpose is to have:
> - common naming scheme (at least for the ice we have patch ~ready);
> - less "customer frustration";
> - easier job for analytical scripts, copying from wiki:
> | The naming schema was created to be human readable and easily parsed
> | by an analytic engine (such as a script or other entity).
> | All statistic strings will be comprised of three components:
> | @Where, @Instance and @Units.  Each of these components is separated
> | by an underscore "_"; if a component is comprised of more than one
> | word, then those words are separated by a dash "-".
> |
> | An example statistic that shows this is xdp-rx-dropped_q-23_packets.
> | In this case the @where is xdp-rx-dropped, the @instance is q-32 and
> | the @unit is packets.

That is one of the two main problems with the ethtool -S stats,
everyone comes up with new "common" standards, endlessly.
Queue the "Standards" xkcd.

Once we have a netlink GET for queues we can plonk the per queue stats
there pretty easily.

  reply	other threads:[~2023-08-19  0:01 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-16  0:42 [PATCH net-next v5 00/15][pull request] Introduce Intel IDPF driver Tony Nguyen
2023-08-16  0:42 ` [PATCH net-next v5 01/15] virtchnl: add virtchnl version 2 ops Tony Nguyen
2023-08-16  0:42 ` [PATCH net-next v5 02/15] idpf: add module register and probe functionality Tony Nguyen
2023-08-16  0:42 ` [PATCH net-next v5 03/15] idpf: add controlq init and reset checks Tony Nguyen
2023-08-16  0:42 ` [PATCH net-next v5 04/15] idpf: add core init and interrupt request Tony Nguyen
2023-08-16  0:42 ` [PATCH net-next v5 05/15] idpf: add create vport and netdev configuration Tony Nguyen
2023-08-16  0:42 ` [PATCH net-next v5 06/15] idpf: add ptypes and MAC filter support Tony Nguyen
2023-08-16  0:42 ` [PATCH net-next v5 07/15] idpf: configure resources for TX queues Tony Nguyen
2023-08-16  0:42 ` [PATCH net-next v5 08/15] idpf: configure resources for RX queues Tony Nguyen
2023-08-18  2:58   ` Jakub Kicinski
2023-08-18 17:36     ` Linga, Pavan Kumar
2023-08-16  0:42 ` [PATCH net-next v5 09/15] idpf: initialize interrupts and enable vport Tony Nguyen
2023-08-16  0:43 ` [PATCH net-next v5 10/15] idpf: add splitq start_xmit Tony Nguyen
2023-08-18 18:37   ` Jakub Kicinski
2023-08-21 20:42     ` Linga, Pavan Kumar
2023-08-16  0:43 ` [PATCH net-next v5 11/15] idpf: add TX splitq napi poll support Tony Nguyen
2023-08-18 18:42   ` Jakub Kicinski
2023-08-16  0:43 ` [PATCH net-next v5 12/15] idpf: add RX " Tony Nguyen
2023-08-18 18:46   ` Jakub Kicinski
2023-08-16  0:43 ` [PATCH net-next v5 13/15] idpf: add singleq start_xmit and napi poll Tony Nguyen
2023-08-18 18:47   ` Jakub Kicinski
2023-08-16  0:43 ` [PATCH net-next v5 14/15] idpf: add ethtool callbacks Tony Nguyen
2023-08-18 18:58   ` Jakub Kicinski
2023-08-18 22:42     ` Przemek Kitszel
2023-08-19  0:01       ` Jakub Kicinski [this message]
2023-08-21 20:41     ` Linga, Pavan Kumar
2023-08-21 21:02       ` Jakub Kicinski
2023-08-23 18:05         ` Linga, Pavan Kumar
2023-08-16  0:43 ` [PATCH net-next v5 15/15] idpf: configure SRIOV and add other ndo_ops Tony Nguyen
2023-08-18  3:02   ` Jakub Kicinski
2023-08-18 17:41     ` Linga, Pavan Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230818170121.3112bb0a@kernel.org \
    --to=kuba@kernel.org \
    --cc=alan.brady@intel.com \
    --cc=alice.michael@intel.com \
    --cc=andrew@lunn.ch \
    --cc=anthony.l.nguyen@intel.com \
    --cc=davem@davemloft.net \
    --cc=decot@google.com \
    --cc=edumazet@google.com \
    --cc=emil.s.tantilov@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=joshua.a.hay@intel.com \
    --cc=leon@kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pavan.kumar.linga@intel.com \
    --cc=phani.r.burra@intel.com \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=shannon.nelson@amd.com \
    --cc=shiraz.saleem@intel.com \
    --cc=simon.horman@corigine.com \
    --cc=sindhu.devale@intel.com \
    --cc=sridhar.samudrala@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).