From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA8C7634 for ; Sat, 19 Aug 2023 01:33:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BA794C433C8; Sat, 19 Aug 2023 01:33:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692408795; bh=eQsDnVRcEoBkIR035KXsBsK1ZgEoecLvJBhlfQqPdvo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oo2h163uvr5HkeY9eXN8I13GpuAxwj82iwdkWJRNvXGueeQjJzVI1wg2ww2kootiX BOVZEjnlMwvuagtOGJGXD+ULBRIQfFEwLJPBtTSvvhRmE2lvfkSgfJMGiWTWNUBl2d eTyxlrW/En3wvKguy8EPt/fnSJdJvAT24dS3aYurZN44OggxY2hzJ707984EvwAS9W BFzf8J57P3niIwJ14Kk309Z80y3ivkjKHJT83nrDEmttwQPFzuE1uXjenECTkDwWiX qBtqnSltRcmeOJJKhc4AEcTtN4nZlF/7ash+D3wKJZDjrrLQUnvknu8PrWTyiPErSx WVyc4zzWA3NJQ== Date: Fri, 18 Aug 2023 18:33:13 -0700 From: Jakub Kicinski To: Daniel Golle Cc: Felix Fietkau , John Crispin , Sean Wang , Mark Lee , Lorenzo Bianconi , "David S. Miller" , Eric Dumazet , Paolo Abeni , Matthias Brugger , AngeloGioacchino Del Regno , Sujuan Chen , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH net] net: ethernet: mtk_eth_soc: fix NULL pointer on hw reset Message-ID: <20230818183313.52f9b9f3@kernel.org> In-Reply-To: <6863f378a2a077701c60cea6ae654212e919d624.1692273610.git.daniel@makrotopia.org> References: <6863f378a2a077701c60cea6ae654212e919d624.1692273610.git.daniel@makrotopia.org> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 17 Aug 2023 13:01:11 +0100 Daniel Golle wrote: > Initialize the hw_list will 0s and break out of both functions in case > a hw_list entry is 0. Static variables are always initialized to 0, I don't think that part is need. -- pw-bot: cr