netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>, Dima Chumak <dchumak@nvidia.com>,
	Jiri Pirko <jiri@resnulli.us>, Jonathan Corbet <corbet@lwn.net>,
	linux-doc@vger.kernel.org, netdev@vger.kernel.org,
	Saeed Mahameed <saeedm@nvidia.com>,
	Steffen Klassert <steffen.klassert@secunet.com>,
	Simon Horman <simon.horman@corigine.com>
Subject: Re: [PATCH net-next v3 0/8] devlink: Add port function attributes
Date: Fri, 18 Aug 2023 21:36:40 +0300	[thread overview]
Message-ID: <20230818183640.GA22185@unreal> (raw)
In-Reply-To: <20230818093812.7ede8fbc@kernel.org>

On Fri, Aug 18, 2023 at 09:38:12AM -0700, Jakub Kicinski wrote:
> On Fri, 18 Aug 2023 07:19:59 +0300 Leon Romanovsky wrote:
> > It is very strange to expect 1 series per vendor/driver without taking
> > into account the size of that driver and the amount of upstream work
> > involvement from that vendor.
> 
> According to the "reviewer rotation" nVidia is supposed to be reviewing
> this week. Sorry it fell on you in particular, but as a company y'all
> definitely are not pulling your weight.

I can't speak for my company and for my colleagues who are OOO during
these days because of summer break, but only for me.

I'm trying my best to review and reduce maintainers burden. Should I stop?

> Then Saeed pings me to pull your RDMA stuff faster

Saeed explained to you why he needs it faster - merge conflict.

> and you have to audacity to call the basic rules we had for a very long
> time "very strange".

This rule relies on basic contract of 1 series -> fast review/acceptance.
Once fast review/acceptance doesn't happen, what else do you expect from me?

Thanks

> 
> SMH

  reply	other threads:[~2023-08-18 18:36 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-17  9:11 [PATCH net-next v3 0/8] devlink: Add port function attributes Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 1/8] devlink: Expose port function commands to control IPsec crypto offloads Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 2/8] devlink: Expose port function commands to control IPsec packet offloads Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 3/8] net/mlx5: Drop extra layer of locks in IPsec Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 4/8] net/mlx5e: Rewrite IPsec vs. TC block interface Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 5/8] net/mlx5: Add IFC bits to support IPsec enable/disable Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 6/8] net/mlx5: Provide an interface to block change of IPsec capabilities Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 7/8] net/mlx5: Implement devlink port function cmds to control ipsec_crypto Leon Romanovsky
2023-08-17  9:11 ` [PATCH net-next v3 8/8] net/mlx5: Implement devlink port function cmds to control ipsec_packet Leon Romanovsky
2023-08-18  3:07 ` [PATCH net-next v3 0/8] devlink: Add port function attributes Jakub Kicinski
2023-08-18  4:19   ` Leon Romanovsky
2023-08-18 16:38     ` Jakub Kicinski
2023-08-18 18:36       ` Leon Romanovsky [this message]
2023-08-18 21:32         ` Jakub Kicinski
2023-08-21 20:41           ` Saeed Mahameed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230818183640.GA22185@unreal \
    --to=leon@kernel.org \
    --cc=corbet@lwn.net \
    --cc=davem@davemloft.net \
    --cc=dchumak@nvidia.com \
    --cc=edumazet@google.com \
    --cc=jiri@resnulli.us \
    --cc=kuba@kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=saeedm@nvidia.com \
    --cc=simon.horman@corigine.com \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).