From: Leon Romanovsky <leon@kernel.org>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, opendmb@gmail.com,
florian.fainelli@broadcom.com, pgynther@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net v3 1/2] net: bgmac: Fix return value check for fixed_phy_register()
Date: Fri, 18 Aug 2023 21:57:06 +0300 [thread overview]
Message-ID: <20230818185706.GJ22185@unreal> (raw)
In-Reply-To: <20230818051221.3634844-2-ruanjinjie@huawei.com>
On Fri, Aug 18, 2023 at 01:12:20PM +0800, Ruan Jinjie wrote:
> The fixed_phy_register() function returns error pointers and never
> returns NULL. Update the checks accordingly.
>
> Fixes: c25b23b8a387 ("bgmac: register fixed PHY for ARM BCM470X / BCM5301X chipsets")
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> ---
> v3:
> - Split the err code update code into another patch set as suggested.
> v2:
> - Remove redundant NULL check and fix the return value.
> - Update the commit title and message.
> - Add the fix tag.
> ---
> drivers/net/ethernet/broadcom/bgmac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
next prev parent reply other threads:[~2023-08-18 18:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 5:12 [PATCH net v3 0/2] net: Fix return value check for fixed_phy_register() Ruan Jinjie
2023-08-18 5:12 ` [PATCH net v3 1/2] net: bgmac: " Ruan Jinjie
2023-08-18 18:57 ` Leon Romanovsky [this message]
2023-08-18 5:12 ` [PATCH net v3 2/2] net: bcmgenet: " Ruan Jinjie
2023-08-18 18:56 ` Leon Romanovsky
2023-08-19 0:28 ` Doug Berger
2023-08-20 10:06 ` [PATCH net v3 0/2] net: " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818185706.GJ22185@unreal \
--to=leon@kernel.org \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=pgynther@google.com \
--cc=rafal@milecki.pl \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).