* Re: [PATCH net-next] net: freescale: Remove unused declarations
2023-08-17 13:41 [PATCH net-next] net: freescale: Remove unused declarations Yue Haibing
@ 2023-08-17 16:34 ` Sean Anderson
2023-08-18 7:03 ` Madalin Bucur
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Sean Anderson @ 2023-08-17 16:34 UTC (permalink / raw)
To: Yue Haibing, madalin.bucur, davem, edumazet, kuba, pabeni,
pantelis.antoniou, camelia.groza, christophe.leroy
Cc: netdev, linuxppc-dev
On 8/17/23 09:41, Yue Haibing wrote:
> Commit 5d93cfcf7360 ("net: dpaa: Convert to phylink") removed
> fman_set_mac_active_pause()/fman_get_pause_cfg() but not declarations.
> Commit 48257c4f168e ("Add fs_enet ethernet network driver, for several
> embedded platforms.") declared but never implemented
> fs_enet_platform_init() and fs_enet_platform_cleanup().
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/freescale/fman/mac.h | 4 ----
> drivers/net/ethernet/freescale/fs_enet/fs_enet.h | 5 -----
> 2 files changed, 9 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fman/mac.h b/drivers/net/ethernet/freescale/fman/mac.h
> index ad06f8d7924b..fe747915cc73 100644
> --- a/drivers/net/ethernet/freescale/fman/mac.h
> +++ b/drivers/net/ethernet/freescale/fman/mac.h
> @@ -68,10 +68,6 @@ struct dpaa_eth_data {
>
> extern const char *mac_driver_description;
>
> -int fman_set_mac_active_pause(struct mac_device *mac_dev, bool rx, bool tx);
> -
> -void fman_get_pause_cfg(struct mac_device *mac_dev, bool *rx_pause,
> - bool *tx_pause);
> int fman_set_multi(struct net_device *net_dev, struct mac_device *mac_dev);
>
> #endif /* __MAC_H */
> diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> index d371072fff60..759bb7080e22 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> @@ -208,11 +208,6 @@ void fs_cleanup_bds(struct net_device *dev);
> #define DRV_MODULE_NAME "fs_enet"
> #define PFX DRV_MODULE_NAME ": "
>
> -/***************************************************************************/
> -
> -int fs_enet_platform_init(void);
> -void fs_enet_platform_cleanup(void);
> -
> /***************************************************************************/
> /* buffer descriptor access macros */
>
Reviewed-by: Sean Anderson <sean.anderson@seco.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* RE: [PATCH net-next] net: freescale: Remove unused declarations
2023-08-17 13:41 [PATCH net-next] net: freescale: Remove unused declarations Yue Haibing
2023-08-17 16:34 ` Sean Anderson
@ 2023-08-18 7:03 ` Madalin Bucur
2023-08-18 18:57 ` Leon Romanovsky
2023-08-19 2:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Madalin Bucur @ 2023-08-18 7:03 UTC (permalink / raw)
To: Yue Haibing, Sean Anderson, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
pantelis.antoniou@gmail.com, Camelia Alexandra Groza,
christophe.leroy@csgroup.eu
Cc: netdev@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
> -----Original Message-----
> From: Yue Haibing <yuehaibing@huawei.com>
> Sent: 17 August 2023 16:42
> To: Madalin Bucur <madalin.bucur@nxp.com>; Sean Anderson
> <sean.anderson@seco.com>; davem@davemloft.net; edumazet@google.com;
> kuba@kernel.org; pabeni@redhat.com; pantelis.antoniou@gmail.com; Camelia
> Alexandra Groza <camelia.groza@nxp.com>; christophe.leroy@csgroup.eu;
> yuehaibing@huawei.com
> Cc: netdev@vger.kernel.org; linuxppc-dev@lists.ozlabs.org
> Subject: [PATCH net-next] net: freescale: Remove unused declarations
>
> Commit 5d93cfcf7360 ("net: dpaa: Convert to phylink") removed
> fman_set_mac_active_pause()/fman_get_pause_cfg() but not declarations.
> Commit 48257c4f168e ("Add fs_enet ethernet network driver, for several
> embedded platforms.") declared but never implemented
> fs_enet_platform_init() and fs_enet_platform_cleanup().
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/freescale/fman/mac.h | 4 ----
> drivers/net/ethernet/freescale/fs_enet/fs_enet.h | 5 -----
> 2 files changed, 9 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/fman/mac.h
> b/drivers/net/ethernet/freescale/fman/mac.h
> index ad06f8d7924b..fe747915cc73 100644
> --- a/drivers/net/ethernet/freescale/fman/mac.h
> +++ b/drivers/net/ethernet/freescale/fman/mac.h
> @@ -68,10 +68,6 @@ struct dpaa_eth_data {
>
> extern const char *mac_driver_description;
>
> -int fman_set_mac_active_pause(struct mac_device *mac_dev, bool rx, bool
> tx);
> -
> -void fman_get_pause_cfg(struct mac_device *mac_dev, bool *rx_pause,
> - bool *tx_pause);
> int fman_set_multi(struct net_device *net_dev, struct mac_device
> *mac_dev);
>
> #endif /* __MAC_H */
> diff --git a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> index d371072fff60..759bb7080e22 100644
> --- a/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> +++ b/drivers/net/ethernet/freescale/fs_enet/fs_enet.h
> @@ -208,11 +208,6 @@ void fs_cleanup_bds(struct net_device *dev);
> #define DRV_MODULE_NAME "fs_enet"
> #define PFX DRV_MODULE_NAME ": "
>
> -
> /************************************************************************
> ***/
> -
> -int fs_enet_platform_init(void);
> -void fs_enet_platform_cleanup(void);
> -
>
> /************************************************************************
> ***/
> /* buffer descriptor access macros */
>
> --
> 2.34.1
Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] net: freescale: Remove unused declarations
2023-08-17 13:41 [PATCH net-next] net: freescale: Remove unused declarations Yue Haibing
2023-08-17 16:34 ` Sean Anderson
2023-08-18 7:03 ` Madalin Bucur
@ 2023-08-18 18:57 ` Leon Romanovsky
2023-08-19 2:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Leon Romanovsky @ 2023-08-18 18:57 UTC (permalink / raw)
To: Yue Haibing
Cc: madalin.bucur, sean.anderson, davem, edumazet, kuba, pabeni,
pantelis.antoniou, camelia.groza, christophe.leroy, netdev,
linuxppc-dev
On Thu, Aug 17, 2023 at 09:41:59PM +0800, Yue Haibing wrote:
> Commit 5d93cfcf7360 ("net: dpaa: Convert to phylink") removed
> fman_set_mac_active_pause()/fman_get_pause_cfg() but not declarations.
> Commit 48257c4f168e ("Add fs_enet ethernet network driver, for several
> embedded platforms.") declared but never implemented
> fs_enet_platform_init() and fs_enet_platform_cleanup().
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
> drivers/net/ethernet/freescale/fman/mac.h | 4 ----
> drivers/net/ethernet/freescale/fs_enet/fs_enet.h | 5 -----
> 2 files changed, 9 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH net-next] net: freescale: Remove unused declarations
2023-08-17 13:41 [PATCH net-next] net: freescale: Remove unused declarations Yue Haibing
` (2 preceding siblings ...)
2023-08-18 18:57 ` Leon Romanovsky
@ 2023-08-19 2:50 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-19 2:50 UTC (permalink / raw)
To: Yue Haibing
Cc: madalin.bucur, sean.anderson, davem, edumazet, kuba, pabeni,
pantelis.antoniou, camelia.groza, christophe.leroy, netdev,
linuxppc-dev
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 17 Aug 2023 21:41:59 +0800 you wrote:
> Commit 5d93cfcf7360 ("net: dpaa: Convert to phylink") removed
> fman_set_mac_active_pause()/fman_get_pause_cfg() but not declarations.
> Commit 48257c4f168e ("Add fs_enet ethernet network driver, for several
> embedded platforms.") declared but never implemented
> fs_enet_platform_init() and fs_enet_platform_cleanup().
>
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>
> [...]
Here is the summary with links:
- [net-next] net: freescale: Remove unused declarations
https://git.kernel.org/netdev/net-next/c/cb49ec034924
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread