From: Jakub Kicinski <kuba@kernel.org>
To: Hariprasad Kelam <hkelam@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<davem@davemloft.net>, <sgoutham@marvell.com>,
<gakula@marvell.com>, <jerinj@marvell.com>,
<lcherian@marvell.com>, <sbhatta@marvell.com>,
<naveenm@marvell.com>, <edumazet@google.com>, <pabeni@redhat.com>
Subject: Re: [net-next Patch 4/5] octeontx2-af: replace generic error codes
Date: Fri, 18 Aug 2023 19:50:41 -0700 [thread overview]
Message-ID: <20230818195041.1fd54fb3@kernel.org> (raw)
In-Reply-To: <20230817112357.25874-5-hkelam@marvell.com>
On Thu, 17 Aug 2023 16:53:56 +0530 Hariprasad Kelam wrote:
> currently, if any netdev is not mapped to the MAC block(cgx/rpm)
> requests MAC feature, AF driver returns a generic error like -EPERM.
> This patch replaces generic error codes with driver-specific error
> codes for better debugging
The custom error codes are not liked upstream, they make much harder
for people who don't work on the driver to refactor it.
If you want debugging isn't it better to add a tracepoint to the
checks?
--
pw-bot: cr
next prev parent reply other threads:[~2023-08-19 2:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 11:23 [net-next Patch 0/5] octeontx2-af: misc MAC block changes Hariprasad Kelam
2023-08-17 11:23 ` [net-next Patch 1/5] octeontx2-af: CN10KB: Add USGMII LMAC mode Hariprasad Kelam
2023-08-17 11:23 ` [net-next Patch 2/5] octeontx2-af: Don't treat lack of CGX interfaces as error Hariprasad Kelam
2023-08-17 11:23 ` [net-next Patch 3/5] octeontx2-af: Add validation of lmac Hariprasad Kelam
2023-08-17 11:23 ` [net-next Patch 4/5] octeontx2-af: replace generic error codes Hariprasad Kelam
2023-08-19 2:50 ` Jakub Kicinski [this message]
2023-08-20 4:12 ` Hariprasad Kelam
2023-08-24 5:41 ` Hariprasad Kelam
2023-08-24 15:19 ` Jakub Kicinski
2023-08-25 7:20 ` Hariprasad Kelam
2023-08-17 11:23 ` [net-next Patch 5/5] octeontx2-af: print error message incase of invalid pf mapping Hariprasad Kelam
2023-08-18 10:55 ` [net-next Patch 0/5] octeontx2-af: misc MAC block changes Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230818195041.1fd54fb3@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=jerinj@marvell.com \
--cc=lcherian@marvell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=naveenm@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).