* [PATCH net-next v2] net: release reference to inet6_dev pointer
@ 2023-08-18 18:22 Patrick Rohr
2023-08-19 16:34 ` Leon Romanovsky
2023-08-20 18:13 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Patrick Rohr @ 2023-08-18 18:22 UTC (permalink / raw)
To: David S. Miller
Cc: Linux Network Development Mailing List, Patrick Rohr,
Maciej Żenczykowski, Lorenzo Colitti, David Ahern,
Simon Horman
addrconf_prefix_rcv returned early without releasing the inet6_dev
pointer when the PIO lifetime is less than accept_ra_min_lft.
Fixes: 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes")
Cc: Maciej Żenczykowski <maze@google.com>
Cc: Lorenzo Colitti <lorenzo@google.com>
Cc: David Ahern <dsahern@kernel.org>
Cc: Simon Horman <horms@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Maciej Żenczykowski <maze@google.com>
Signed-off-by: Patrick Rohr <prohr@google.com>
---
net/ipv6/addrconf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c
index 5184bd0ceb12..47d1dd8501b7 100644
--- a/net/ipv6/addrconf.c
+++ b/net/ipv6/addrconf.c
@@ -2742,7 +2742,7 @@ void addrconf_prefix_rcv(struct net_device *dev, u8 *opt, int len, bool sllao)
}
if (valid_lft != 0 && valid_lft < in6_dev->cnf.accept_ra_min_lft)
- return;
+ goto put;
/*
* Two things going on here:
--
2.42.0.rc1.204.g551eb34607-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next v2] net: release reference to inet6_dev pointer
2023-08-18 18:22 [PATCH net-next v2] net: release reference to inet6_dev pointer Patrick Rohr
@ 2023-08-19 16:34 ` Leon Romanovsky
2023-08-20 18:13 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Leon Romanovsky @ 2023-08-19 16:34 UTC (permalink / raw)
To: Patrick Rohr
Cc: David S. Miller, Linux Network Development Mailing List,
Maciej Żenczykowski, Lorenzo Colitti, David Ahern,
Simon Horman
On Fri, Aug 18, 2023 at 11:22:49AM -0700, Patrick Rohr wrote:
> addrconf_prefix_rcv returned early without releasing the inet6_dev
> pointer when the PIO lifetime is less than accept_ra_min_lft.
>
> Fixes: 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes")
> Cc: Maciej Żenczykowski <maze@google.com>
> Cc: Lorenzo Colitti <lorenzo@google.com>
> Cc: David Ahern <dsahern@kernel.org>
> Cc: Simon Horman <horms@kernel.org>
> Reviewed-by: Simon Horman <horms@kernel.org>
> Reviewed-by: Maciej Żenczykowski <maze@google.com>
> Signed-off-by: Patrick Rohr <prohr@google.com>
> ---
> net/ipv6/addrconf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks,
Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next v2] net: release reference to inet6_dev pointer
2023-08-18 18:22 [PATCH net-next v2] net: release reference to inet6_dev pointer Patrick Rohr
2023-08-19 16:34 ` Leon Romanovsky
@ 2023-08-20 18:13 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-20 18:13 UTC (permalink / raw)
To: Patrick Rohr; +Cc: davem, netdev, maze, lorenzo, dsahern, horms
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Fri, 18 Aug 2023 11:22:49 -0700 you wrote:
> addrconf_prefix_rcv returned early without releasing the inet6_dev
> pointer when the PIO lifetime is less than accept_ra_min_lft.
>
> Fixes: 5027d54a9c30 ("net: change accept_ra_min_rtr_lft to affect all RA lifetimes")
> Cc: Maciej Żenczykowski <maze@google.com>
> Cc: Lorenzo Colitti <lorenzo@google.com>
> Cc: David Ahern <dsahern@kernel.org>
> Cc: Simon Horman <horms@kernel.org>
> Reviewed-by: Simon Horman <horms@kernel.org>
> Reviewed-by: Maciej Żenczykowski <maze@google.com>
> Signed-off-by: Patrick Rohr <prohr@google.com>
>
> [...]
Here is the summary with links:
- [net-next,v2] net: release reference to inet6_dev pointer
https://git.kernel.org/netdev/net-next/c/5cb249686e67
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-20 18:13 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-18 18:22 [PATCH net-next v2] net: release reference to inet6_dev pointer Patrick Rohr
2023-08-19 16:34 ` Leon Romanovsky
2023-08-20 18:13 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).