From: Jinjie Ruan <ruanjinjie@huawei.com>
To: <rafal@milecki.pl>, <bcm-kernel-feedback-list@broadcom.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>, <opendmb@gmail.com>,
<florian.fainelli@broadcom.com>, <bryan.whitehead@microchip.com>,
<UNGLinuxDriver@microchip.com>, <netdev@vger.kernel.org>,
<andrew@lunn.ch>
Cc: <ruanjinjie@huawei.com>
Subject: [PATCH net-next v4 0/3] net: Return PTR_ERR() for fixed_phy_register()
Date: Mon, 21 Aug 2023 10:50:17 +0800 [thread overview]
Message-ID: <20230821025020.1971520-1-ruanjinjie@huawei.com> (raw)
fixed_phy_register() returns not only -EIO or -ENODEV, but also
-EPROBE_DEFER, -EINVAL and -EBUSY. The Best practice is to return these
error codes with PTR_ERR().
Changes in v4:
- Keep the code context consistent with another patch set.
- Update to bring the author's name before.
Jinjie Ruan (3):
net: bgmac: Return PTR_ERR() for fixed_phy_register()
net: bcmgenet: Return PTR_ERR() for fixed_phy_register()
net: lan743x: Return PTR_ERR() for fixed_phy_register()
drivers/net/ethernet/broadcom/bgmac.c | 2 +-
drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 +-
drivers/net/ethernet/microchip/lan743x_main.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
--
2.34.1
next reply other threads:[~2023-08-21 2:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 2:50 Jinjie Ruan [this message]
2023-08-21 2:50 ` [PATCH net-next v4 1/3] net: bgmac: Return PTR_ERR() for fixed_phy_register() Jinjie Ruan
2023-08-21 2:50 ` [PATCH net-next v4 2/3] net: bcmgenet: " Jinjie Ruan
2023-08-21 2:50 ` [PATCH net-next v4 3/3] net: lan743x: " Jinjie Ruan
2023-08-23 0:03 ` Jakub Kicinski
2023-08-23 7:43 ` Ruan Jinjie
2023-08-23 14:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230821025020.1971520-1-ruanjinjie@huawei.com \
--to=ruanjinjie@huawei.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).