[PATCH net-next] ionic: Remove unused declarations

[PATCH net-next] ionic: Remove unused declarations

[Yue Haibing]

Commit fbfb8031533c ("ionic: Add hardware init and device commands")
declared but never implemented ionic_q_rewind()/ionic_set_dma_mask().
Commit 969f84394604 ("ionic: sync the filters in the work task")
declared but never implemented ionic_rx_filters_need_sync().

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/pensando/ionic/ionic.h           | 1 -
 drivers/net/ethernet/pensando/ionic/ionic_dev.h       | 1 -
 drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h | 1 -
 3 files changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/pensando/ionic/ionic.h b/drivers/net/ethernet/pensando/ionic/ionic.h
index 602f4d45d529..2453a40f6ee8 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic.h
+++ b/drivers/net/ethernet/pensando/ionic/ionic.h
@@ -81,7 +81,6 @@ int ionic_dev_cmd_wait(struct ionic *ionic, unsigned long max_wait);
 int ionic_dev_cmd_wait_nomsg(struct ionic *ionic, unsigned long max_wait);
 void ionic_dev_cmd_dev_err_print(struct ionic *ionic, u8 opcode, u8 status,
 				 int err);
-int ionic_set_dma_mask(struct ionic *ionic);
 int ionic_setup(struct ionic *ionic);
 
 int ionic_identify(struct ionic *ionic);
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_dev.h b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
index 0bea208bfba2..6aac98bcb9f4 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_dev.h
+++ b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
@@ -376,7 +376,6 @@ void ionic_q_cmb_map(struct ionic_queue *q, void __iomem *base, dma_addr_t base_
 void ionic_q_sg_map(struct ionic_queue *q, void *base, dma_addr_t base_pa);
 void ionic_q_post(struct ionic_queue *q, bool ring_doorbell, ionic_desc_cb cb,
 		  void *cb_arg);
-void ionic_q_rewind(struct ionic_queue *q, struct ionic_desc_info *start);
 void ionic_q_service(struct ionic_queue *q, struct ionic_cq_info *cq_info,
 		     unsigned int stop_index);
 int ionic_heartbeat_check(struct ionic *ionic);
diff --git a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h
index 87b2666f248b..ee9e99cd1b5e 100644
--- a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h
+++ b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h
@@ -43,7 +43,6 @@ struct ionic_rx_filter *ionic_rx_filter_by_addr(struct ionic_lif *lif, const u8
 struct ionic_rx_filter *ionic_rx_filter_rxsteer(struct ionic_lif *lif);
 void ionic_rx_filter_sync(struct ionic_lif *lif);
 int ionic_lif_list_addr(struct ionic_lif *lif, const u8 *addr, bool mode);
-int ionic_rx_filters_need_sync(struct ionic_lif *lif);
 int ionic_lif_vlan_add(struct ionic_lif *lif, const u16 vid);
 int ionic_lif_vlan_del(struct ionic_lif *lif, const u16 vid);
 
-- 
2.34.1

Re: [PATCH net-next] ionic: Remove unused declarations

[Brett Creeley]

On 8/21/2023 6:47 AM, Yue Haibing wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> Commit fbfb8031533c ("ionic: Add hardware init and device commands")
> declared but never implemented ionic_q_rewind()/ionic_set_dma_mask().
> Commit 969f84394604 ("ionic: sync the filters in the work task")
> declared but never implemented ionic_rx_filters_need_sync().
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> ---
>   drivers/net/ethernet/pensando/ionic/ionic.h           | 1 -
>   drivers/net/ethernet/pensando/ionic/ionic_dev.h       | 1 -
>   drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h | 1 -
>   3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic.h b/drivers/net/ethernet/pensando/ionic/ionic.h
> index 602f4d45d529..2453a40f6ee8 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic.h
> +++ b/drivers/net/ethernet/pensando/ionic/ionic.h
> @@ -81,7 +81,6 @@ int ionic_dev_cmd_wait(struct ionic *ionic, unsigned long max_wait);
>   int ionic_dev_cmd_wait_nomsg(struct ionic *ionic, unsigned long max_wait);
>   void ionic_dev_cmd_dev_err_print(struct ionic *ionic, u8 opcode, u8 status,
>                                   int err);
> -int ionic_set_dma_mask(struct ionic *ionic);
>   int ionic_setup(struct ionic *ionic);
> 
>   int ionic_identify(struct ionic *ionic);
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_dev.h b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
> index 0bea208bfba2..6aac98bcb9f4 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_dev.h
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
> @@ -376,7 +376,6 @@ void ionic_q_cmb_map(struct ionic_queue *q, void __iomem *base, dma_addr_t base_
>   void ionic_q_sg_map(struct ionic_queue *q, void *base, dma_addr_t base_pa);
>   void ionic_q_post(struct ionic_queue *q, bool ring_doorbell, ionic_desc_cb cb,
>                    void *cb_arg);
> -void ionic_q_rewind(struct ionic_queue *q, struct ionic_desc_info *start);
>   void ionic_q_service(struct ionic_queue *q, struct ionic_cq_info *cq_info,
>                       unsigned int stop_index);
>   int ionic_heartbeat_check(struct ionic *ionic);
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h
> index 87b2666f248b..ee9e99cd1b5e 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h
> @@ -43,7 +43,6 @@ struct ionic_rx_filter *ionic_rx_filter_by_addr(struct ionic_lif *lif, const u8
>   struct ionic_rx_filter *ionic_rx_filter_rxsteer(struct ionic_lif *lif);
>   void ionic_rx_filter_sync(struct ionic_lif *lif);
>   int ionic_lif_list_addr(struct ionic_lif *lif, const u8 *addr, bool mode);
> -int ionic_rx_filters_need_sync(struct ionic_lif *lif);
>   int ionic_lif_vlan_add(struct ionic_lif *lif, const u16 vid);
>   int ionic_lif_vlan_del(struct ionic_lif *lif, const u16 vid);
> 
> --
> 2.34.1
> 

LGTM! Thanks for the cleanup.

Reviewed-by: Brett Creeley <brett.creeley@amd.com>

Re: [PATCH net-next] ionic: Remove unused declarations

[Nelson, Shannon]

On 8/21/2023 6:47 AM, Yue Haibing wrote:
> 
> Commit fbfb8031533c ("ionic: Add hardware init and device commands")
> declared but never implemented ionic_q_rewind()/ionic_set_dma_mask().
> Commit 969f84394604 ("ionic: sync the filters in the work task")
> declared but never implemented ionic_rx_filters_need_sync().
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

This should include a "Fixes" tag
sln

> ---
>   drivers/net/ethernet/pensando/ionic/ionic.h           | 1 -
>   drivers/net/ethernet/pensando/ionic/ionic_dev.h       | 1 -
>   drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h | 1 -
>   3 files changed, 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic.h b/drivers/net/ethernet/pensando/ionic/ionic.h
> index 602f4d45d529..2453a40f6ee8 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic.h
> +++ b/drivers/net/ethernet/pensando/ionic/ionic.h
> @@ -81,7 +81,6 @@ int ionic_dev_cmd_wait(struct ionic *ionic, unsigned long max_wait);
>   int ionic_dev_cmd_wait_nomsg(struct ionic *ionic, unsigned long max_wait);
>   void ionic_dev_cmd_dev_err_print(struct ionic *ionic, u8 opcode, u8 status,
>                                   int err);
> -int ionic_set_dma_mask(struct ionic *ionic);
>   int ionic_setup(struct ionic *ionic);
> 
>   int ionic_identify(struct ionic *ionic);
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_dev.h b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
> index 0bea208bfba2..6aac98bcb9f4 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_dev.h
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
> @@ -376,7 +376,6 @@ void ionic_q_cmb_map(struct ionic_queue *q, void __iomem *base, dma_addr_t base_
>   void ionic_q_sg_map(struct ionic_queue *q, void *base, dma_addr_t base_pa);
>   void ionic_q_post(struct ionic_queue *q, bool ring_doorbell, ionic_desc_cb cb,
>                    void *cb_arg);
> -void ionic_q_rewind(struct ionic_queue *q, struct ionic_desc_info *start);
>   void ionic_q_service(struct ionic_queue *q, struct ionic_cq_info *cq_info,
>                       unsigned int stop_index);
>   int ionic_heartbeat_check(struct ionic *ionic);
> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h
> index 87b2666f248b..ee9e99cd1b5e 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h
> @@ -43,7 +43,6 @@ struct ionic_rx_filter *ionic_rx_filter_by_addr(struct ionic_lif *lif, const u8
>   struct ionic_rx_filter *ionic_rx_filter_rxsteer(struct ionic_lif *lif);
>   void ionic_rx_filter_sync(struct ionic_lif *lif);
>   int ionic_lif_list_addr(struct ionic_lif *lif, const u8 *addr, bool mode);
> -int ionic_rx_filters_need_sync(struct ionic_lif *lif);
>   int ionic_lif_vlan_add(struct ionic_lif *lif, const u16 vid);
>   int ionic_lif_vlan_del(struct ionic_lif *lif, const u16 vid);
> 
> --
> 2.34.1
> 

Re: [PATCH net-next] ionic: Remove unused declarations

[Jakub Kicinski]

On Mon, 21 Aug 2023 10:26:40 -0700 Nelson, Shannon wrote:
> > Commit fbfb8031533c ("ionic: Add hardware init and device commands")
> > declared but never implemented ionic_q_rewind()/ionic_set_dma_mask().
> > Commit 969f84394604 ("ionic: sync the filters in the work task")
> > declared but never implemented ionic_rx_filters_need_sync().
> > 
> > Signed-off-by: Yue Haibing <yuehaibing@huawei.com>  
> 
> This should include a "Fixes" tag

Nope, it's harmless, no Fixes needed.
Fixes is for backporting, why would we backport this.

Re: [PATCH net-next] ionic: Remove unused declarations

[Nelson, Shannon]

On 8/21/2023 10:26 AM, Nelson, Shannon wrote:
> On 8/21/2023 6:47 AM, Yue Haibing wrote:
>>
>> Commit fbfb8031533c ("ionic: Add hardware init and device commands")
>> declared but never implemented ionic_q_rewind()/ionic_set_dma_mask().
>> Commit 969f84394604 ("ionic: sync the filters in the work task")
>> declared but never implemented ionic_rx_filters_need_sync().
>>
>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> 
> This should include a "Fixes" tag
> sln

Let's see if I can make the magic work...
pw-bot: changes-requested


> 
>> ---
>>   drivers/net/ethernet/pensando/ionic/ionic.h           | 1 -
>>   drivers/net/ethernet/pensando/ionic/ionic_dev.h       | 1 -
>>   drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h | 1 -
>>   3 files changed, 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/pensando/ionic/ionic.h 
>> b/drivers/net/ethernet/pensando/ionic/ionic.h
>> index 602f4d45d529..2453a40f6ee8 100644
>> --- a/drivers/net/ethernet/pensando/ionic/ionic.h
>> +++ b/drivers/net/ethernet/pensando/ionic/ionic.h
>> @@ -81,7 +81,6 @@ int ionic_dev_cmd_wait(struct ionic *ionic, unsigned 
>> long max_wait);
>>   int ionic_dev_cmd_wait_nomsg(struct ionic *ionic, unsigned long 
>> max_wait);
>>   void ionic_dev_cmd_dev_err_print(struct ionic *ionic, u8 opcode, u8 
>> status,
>>                                   int err);
>> -int ionic_set_dma_mask(struct ionic *ionic);
>>   int ionic_setup(struct ionic *ionic);
>>
>>   int ionic_identify(struct ionic *ionic);
>> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_dev.h 
>> b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
>> index 0bea208bfba2..6aac98bcb9f4 100644
>> --- a/drivers/net/ethernet/pensando/ionic/ionic_dev.h
>> +++ b/drivers/net/ethernet/pensando/ionic/ionic_dev.h
>> @@ -376,7 +376,6 @@ void ionic_q_cmb_map(struct ionic_queue *q, void 
>> __iomem *base, dma_addr_t base_
>>   void ionic_q_sg_map(struct ionic_queue *q, void *base, dma_addr_t 
>> base_pa);
>>   void ionic_q_post(struct ionic_queue *q, bool ring_doorbell, 
>> ionic_desc_cb cb,
>>                    void *cb_arg);
>> -void ionic_q_rewind(struct ionic_queue *q, struct ionic_desc_info 
>> *start);
>>   void ionic_q_service(struct ionic_queue *q, struct ionic_cq_info 
>> *cq_info,
>>                       unsigned int stop_index);
>>   int ionic_heartbeat_check(struct ionic *ionic);
>> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h 
>> b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h
>> index 87b2666f248b..ee9e99cd1b5e 100644
>> --- a/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h
>> +++ b/drivers/net/ethernet/pensando/ionic/ionic_rx_filter.h
>> @@ -43,7 +43,6 @@ struct ionic_rx_filter 
>> *ionic_rx_filter_by_addr(struct ionic_lif *lif, const u8
>>   struct ionic_rx_filter *ionic_rx_filter_rxsteer(struct ionic_lif *lif);
>>   void ionic_rx_filter_sync(struct ionic_lif *lif);
>>   int ionic_lif_list_addr(struct ionic_lif *lif, const u8 *addr, bool 
>> mode);
>> -int ionic_rx_filters_need_sync(struct ionic_lif *lif);
>>   int ionic_lif_vlan_add(struct ionic_lif *lif, const u16 vid);
>>   int ionic_lif_vlan_del(struct ionic_lif *lif, const u16 vid);
>>
>> -- 
>> 2.34.1
>>

Re: [PATCH net-next] ionic: Remove unused declarations

[Nelson, Shannon]

On 8/21/2023 12:39 PM, Jakub Kicinski wrote:
> 
> On Mon, 21 Aug 2023 10:26:40 -0700 Nelson, Shannon wrote:
>>> Commit fbfb8031533c ("ionic: Add hardware init and device commands")
>>> declared but never implemented ionic_q_rewind()/ionic_set_dma_mask().
>>> Commit 969f84394604 ("ionic: sync the filters in the work task")
>>> declared but never implemented ionic_rx_filters_need_sync().
>>>
>>> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
>>
>> This should include a "Fixes" tag
> 
> Nope, it's harmless, no Fixes needed.
> Fixes is for backporting, why would we backport this.

Okay.

Unfortunately I experimented with sending the "changes requested" 
message to the pw bot just before receiving your note...

sln

Re: [PATCH net-next] ionic: Remove unused declarations

[Jakub Kicinski]

On Mon, 21 Aug 2023 12:42:52 -0700 Nelson, Shannon wrote:
> > Nope, it's harmless, no Fixes needed.
> > Fixes is for backporting, why would we backport this.  
> 
> Okay.
> 
> Unfortunately I experimented with sending the "changes requested" 
> message to the pw bot just before receiving your note...

As luck would have it - seems like something in the copious Outlook
headers confuses python's email library:

$ wget https://lore.kernel.org/all/69e9c563-2f07-4e9e-b43a-145839fe2afd@amd.com/raw
$ python
>>> import email
>>> from email.policy import default
>>> with open('raw', 'rb') as fp:
...   raw = fp.read()
...   msg = email.message_from_bytes(raw, policy=default)
...
>>> msg.get_body(preferencelist=('plain',)).as_string().split('\n')[-1]
''
>>> msg.get_body(preferencelist=('plain',)).as_string().split('\n')[0]
'Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net'


It thinks the headers are the body, so we missed the pw-bot command.

Re: [PATCH net-next] ionic: Remove unused declarations

[Nelson, Shannon]

On 8/21/2023 1:05 PM, Jakub Kicinski wrote:
> 
> On Mon, 21 Aug 2023 12:42:52 -0700 Nelson, Shannon wrote:
>>> Nope, it's harmless, no Fixes needed.
>>> Fixes is for backporting, why would we backport this.
>>
>> Okay.
>>
>> Unfortunately I experimented with sending the "changes requested"
>> message to the pw bot just before receiving your note...
> 
> As luck would have it - seems like something in the copious Outlook
> headers confuses python's email library:

Well, "lucky" me?

Fine...

Acked-by: Shannon Nelson <shannon.nelson@amd.com>

Re: [PATCH net-next] ionic: Remove unused declarations

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 21 Aug 2023 21:47:17 +0800 you wrote:
> Commit fbfb8031533c ("ionic: Add hardware init and device commands")
> declared but never implemented ionic_q_rewind()/ionic_set_dma_mask().
> Commit 969f84394604 ("ionic: sync the filters in the work task")
> declared but never implemented ionic_rx_filters_need_sync().
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> 
> [...]

Here is the summary with links:
  - [net-next] ionic: Remove unused declarations
    https://git.kernel.org/netdev/net-next/c/efa47e80c2bf

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html