[PATCH net-next] qed/qede: Remove unused declarations

[PATCH net-next] qed/qede: Remove unused declarations

[Yue Haibing]

Commit 8cd160a29415 ("qede: convert to new udp_tunnel_nic infra")
removed qede_udp_tunnel_{add,del}() but not the declarations.
Commit 0ebcebbef1cc ("qed: Read device port count from the shmem")
removed qed_device_num_engines() but not its declaration.
Commit 1e128c81290a ("qed: Add support for hardware offloaded FCoE.")
declared but never implemented qed_fcoe_set_pf_params().

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/qlogic/qed/qed.h   | 1 -
 drivers/net/ethernet/qlogic/qede/qede.h | 3 ---
 include/linux/qed/qed_fcoe_if.h         | 3 ---
 3 files changed, 7 deletions(-)

diff --git a/drivers/net/ethernet/qlogic/qed/qed.h b/drivers/net/ethernet/qlogic/qed/qed.h
index d613095b78e0..1d719726f72b 100644
--- a/drivers/net/ethernet/qlogic/qed/qed.h
+++ b/drivers/net/ethernet/qlogic/qed/qed.h
@@ -909,7 +909,6 @@ void qed_configure_vp_wfq_on_link_change(struct qed_dev *cdev,
 					 u32 min_pf_rate);
 
 void qed_clean_wfq_db(struct qed_hwfn *p_hwfn, struct qed_ptt *p_ptt);
-int qed_device_num_engines(struct qed_dev *cdev);
 void qed_set_fw_mac_addr(__le16 *fw_msb,
 			 __le16 *fw_mid, __le16 *fw_lsb, u8 *mac);
 
diff --git a/drivers/net/ethernet/qlogic/qede/qede.h b/drivers/net/ethernet/qlogic/qede/qede.h
index 4d83ceebdc49..042a75f34060 100644
--- a/drivers/net/ethernet/qlogic/qede/qede.h
+++ b/drivers/net/ethernet/qlogic/qede/qede.h
@@ -556,9 +556,6 @@ void qede_config_rx_mode(struct net_device *ndev);
 void qede_fill_rss_params(struct qede_dev *edev,
 			  struct qed_update_vport_rss_params *rss, u8 *update);
 
-void qede_udp_tunnel_add(struct net_device *dev, struct udp_tunnel_info *ti);
-void qede_udp_tunnel_del(struct net_device *dev, struct udp_tunnel_info *ti);
-
 int qede_xdp(struct net_device *dev, struct netdev_bpf *xdp);
 
 #ifdef CONFIG_DCB
diff --git a/include/linux/qed/qed_fcoe_if.h b/include/linux/qed/qed_fcoe_if.h
index 90e3045b2dcb..0d3b6ed21628 100644
--- a/include/linux/qed/qed_fcoe_if.h
+++ b/include/linux/qed/qed_fcoe_if.h
@@ -67,9 +67,6 @@ struct qed_fcoe_cb_ops {
 	 u32 (*get_login_failures)(void *cookie);
 };
 
-void qed_fcoe_set_pf_params(struct qed_dev *cdev,
-			    struct qed_fcoe_pf_params *params);
-
 /**
  * struct qed_fcoe_ops - qed FCoE operations.
  * @common:		common operations pointer
-- 
2.34.1

Re: [PATCH net-next] qed/qede: Remove unused declarations

[Simon Horman]

On Mon, Aug 21, 2023 at 09:00:02PM +0800, Yue Haibing wrote:
> Commit 8cd160a29415 ("qede: convert to new udp_tunnel_nic infra")
> removed qede_udp_tunnel_{add,del}() but not the declarations.
> Commit 0ebcebbef1cc ("qed: Read device port count from the shmem")
> removed qed_device_num_engines() but not its declaration.
> Commit 1e128c81290a ("qed: Add support for hardware offloaded FCoE.")
> declared but never implemented qed_fcoe_set_pf_params().
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] qed/qede: Remove unused declarations

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Mon, 21 Aug 2023 21:00:02 +0800 you wrote:
> Commit 8cd160a29415 ("qede: convert to new udp_tunnel_nic infra")
> removed qede_udp_tunnel_{add,del}() but not the declarations.
> Commit 0ebcebbef1cc ("qed: Read device port count from the shmem")
> removed qed_device_num_engines() but not its declaration.
> Commit 1e128c81290a ("qed: Add support for hardware offloaded FCoE.")
> declared but never implemented qed_fcoe_set_pf_params().
> 
> [...]

Here is the summary with links:
  - [net-next] qed/qede: Remove unused declarations
    https://git.kernel.org/netdev/net-next/c/eb6603246ab9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html