netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] net: ethernet: ti: Remove unused declarations
@ 2023-08-21 13:40 Yue Haibing
  2023-08-21 20:01 ` Simon Horman
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Yue Haibing @ 2023-08-21 13:40 UTC (permalink / raw)
  To: davem, kuba, pabeni, rogerq, yuehaibing; +Cc: netdev

Commit e8609e69470f ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK")
removed am65_cpsw_nuss_adjust_link() but not its declaration.
Commit 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet driver")
declared but never implemented netcp_device_find_module().

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/ti/am65-cpsw-nuss.h | 1 -
 drivers/net/ethernet/ti/netcp.h          | 2 --
 2 files changed, 3 deletions(-)

diff --git a/drivers/net/ethernet/ti/am65-cpsw-nuss.h b/drivers/net/ethernet/ti/am65-cpsw-nuss.h
index bf40c88fbd9b..f3dad2ab9828 100644
--- a/drivers/net/ethernet/ti/am65-cpsw-nuss.h
+++ b/drivers/net/ethernet/ti/am65-cpsw-nuss.h
@@ -192,7 +192,6 @@ struct am65_cpsw_ndev_priv {
 
 extern const struct ethtool_ops am65_cpsw_ethtool_ops_slave;
 
-void am65_cpsw_nuss_adjust_link(struct net_device *ndev);
 void am65_cpsw_nuss_set_p0_ptype(struct am65_cpsw_common *common);
 void am65_cpsw_nuss_remove_tx_chns(struct am65_cpsw_common *common);
 int am65_cpsw_nuss_update_tx_chns(struct am65_cpsw_common *common, int num_tx);
diff --git a/drivers/net/ethernet/ti/netcp.h b/drivers/net/ethernet/ti/netcp.h
index 43d5cd59b56b..7007eb8bed36 100644
--- a/drivers/net/ethernet/ti/netcp.h
+++ b/drivers/net/ethernet/ti/netcp.h
@@ -233,8 +233,6 @@ int netcp_register_rxhook(struct netcp_intf *netcp_priv, int order,
 			  netcp_hook_rtn *hook_rtn, void *hook_data);
 int netcp_unregister_rxhook(struct netcp_intf *netcp_priv, int order,
 			    netcp_hook_rtn *hook_rtn, void *hook_data);
-void *netcp_device_find_module(struct netcp_device *netcp_device,
-			       const char *name);
 
 /* SGMII functions */
 int netcp_sgmii_reset(void __iomem *sgmii_ofs, int port);
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] net: ethernet: ti: Remove unused declarations
  2023-08-21 13:40 [PATCH net-next] net: ethernet: ti: Remove unused declarations Yue Haibing
@ 2023-08-21 20:01 ` Simon Horman
  2023-08-22  7:31 ` Roger Quadros
  2023-08-22 18:00 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2023-08-21 20:01 UTC (permalink / raw)
  To: Yue Haibing; +Cc: davem, kuba, pabeni, rogerq, netdev

On Mon, Aug 21, 2023 at 09:40:29PM +0800, Yue Haibing wrote:
> Commit e8609e69470f ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK")
> removed am65_cpsw_nuss_adjust_link() but not its declaration.
> Commit 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet driver")
> declared but never implemented netcp_device_find_module().
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] net: ethernet: ti: Remove unused declarations
  2023-08-21 13:40 [PATCH net-next] net: ethernet: ti: Remove unused declarations Yue Haibing
  2023-08-21 20:01 ` Simon Horman
@ 2023-08-22  7:31 ` Roger Quadros
  2023-08-22 18:00 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: Roger Quadros @ 2023-08-22  7:31 UTC (permalink / raw)
  To: Yue Haibing, davem, kuba, pabeni; +Cc: netdev



On 21/08/2023 16:40, Yue Haibing wrote:
> Commit e8609e69470f ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK")
> removed am65_cpsw_nuss_adjust_link() but not its declaration.
> Commit 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet driver")
> declared but never implemented netcp_device_find_module().
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Acked-by: Roger Quadros <rogerq@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH net-next] net: ethernet: ti: Remove unused declarations
  2023-08-21 13:40 [PATCH net-next] net: ethernet: ti: Remove unused declarations Yue Haibing
  2023-08-21 20:01 ` Simon Horman
  2023-08-22  7:31 ` Roger Quadros
@ 2023-08-22 18:00 ` patchwork-bot+netdevbpf
  2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-22 18:00 UTC (permalink / raw)
  To: Yue Haibing; +Cc: davem, kuba, pabeni, rogerq, netdev

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 21 Aug 2023 21:40:29 +0800 you wrote:
> Commit e8609e69470f ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK")
> removed am65_cpsw_nuss_adjust_link() but not its declaration.
> Commit 84640e27f230 ("net: netcp: Add Keystone NetCP core ethernet driver")
> declared but never implemented netcp_device_find_module().
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
> 
> [...]

Here is the summary with links:
  - [net-next] net: ethernet: ti: Remove unused declarations
    https://git.kernel.org/netdev/net-next/c/a491add19faf

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-08-22 18:00 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-21 13:40 [PATCH net-next] net: ethernet: ti: Remove unused declarations Yue Haibing
2023-08-21 20:01 ` Simon Horman
2023-08-22  7:31 ` Roger Quadros
2023-08-22 18:00 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).