[PATCH net-next] net: microchip: Remove unused declarations

[PATCH net-next] net: microchip: Remove unused declarations

[Yue Haibing]

Commit 264a9c5c9dff ("net: sparx5: Remove unused GLAG handling in PGID")
removed sparx5_pgid_alloc_glag() but not its declaration.
Commit 27d293cceee5 ("net: microchip: sparx5: Add support for rule count by cookie")
removed vcap_rule_iter() but not its declaration.
Commit 8beef08f4618 ("net: microchip: sparx5: Adding initial VCAP API support")
declared but never implemented vcap_api_set_client().

Signed-off-by: Yue Haibing <yuehaibing@huawei.com>
---
 drivers/net/ethernet/microchip/sparx5/sparx5_main.h   | 1 -
 drivers/net/ethernet/microchip/vcap/vcap_api.h        | 3 ---
 drivers/net/ethernet/microchip/vcap/vcap_api_client.h | 3 ---
 3 files changed, 7 deletions(-)

diff --git a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
index 89a9a7afa32c..6f565c0c0c3d 100644
--- a/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
+++ b/drivers/net/ethernet/microchip/sparx5/sparx5_main.h
@@ -414,7 +414,6 @@ enum sparx5_pgid_type {
 };
 
 void sparx5_pgid_init(struct sparx5 *spx5);
-int sparx5_pgid_alloc_glag(struct sparx5 *spx5, u16 *idx);
 int sparx5_pgid_alloc_mcast(struct sparx5 *spx5, u16 *idx);
 int sparx5_pgid_free(struct sparx5 *spx5, u16 idx);
 
diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api.h b/drivers/net/ethernet/microchip/vcap/vcap_api.h
index 62db270f65af..9eccfa633c1a 100644
--- a/drivers/net/ethernet/microchip/vcap/vcap_api.h
+++ b/drivers/net/ethernet/microchip/vcap/vcap_api.h
@@ -277,7 +277,4 @@ struct vcap_control {
 	struct list_head list; /* list of vcap instances */
 };
 
-/* Set client control interface on the API */
-int vcap_api_set_client(struct vcap_control *vctrl);
-
 #endif /* __VCAP_API__ */
diff --git a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
index d9d1f7c9d762..88641508f885 100644
--- a/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
+++ b/drivers/net/ethernet/microchip/vcap/vcap_api_client.h
@@ -226,9 +226,6 @@ int vcap_chain_offset(struct vcap_control *vctrl, int from_cid, int to_cid);
 bool vcap_is_next_lookup(struct vcap_control *vctrl, int cur_cid, int next_cid);
 /* Is this chain id the last lookup of all VCAPs */
 bool vcap_is_last_chain(struct vcap_control *vctrl, int cid, bool ingress);
-/* Provide all rules via a callback interface */
-int vcap_rule_iter(struct vcap_control *vctrl,
-		   int (*callback)(void *, struct vcap_rule *), void *arg);
 /* Match a list of keys against the keysets available in a vcap type */
 bool vcap_rule_find_keysets(struct vcap_rule *rule,
 			    struct vcap_keyset_list *matches);
-- 
2.34.1

Re: [PATCH net-next] net: microchip: Remove unused declarations

[Simon Horman]

On Mon, Aug 21, 2023 at 09:55:56PM +0800, Yue Haibing wrote:
> Commit 264a9c5c9dff ("net: sparx5: Remove unused GLAG handling in PGID")
> removed sparx5_pgid_alloc_glag() but not its declaration.
> Commit 27d293cceee5 ("net: microchip: sparx5: Add support for rule count by cookie")
> removed vcap_rule_iter() but not its declaration.
> Commit 8beef08f4618 ("net: microchip: sparx5: Adding initial VCAP API support")
> declared but never implemented vcap_api_set_client().
> 
> Signed-off-by: Yue Haibing <yuehaibing@huawei.com>

Reviewed-by: Simon Horman <horms@kernel.org>

Re: [PATCH net-next] net: microchip: Remove unused declarations

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Mon, 21 Aug 2023 21:55:56 +0800 you wrote:
> Commit 264a9c5c9dff ("net: sparx5: Remove unused GLAG handling in PGID")
> removed sparx5_pgid_alloc_glag() but not its declaration.
> Commit 27d293cceee5 ("net: microchip: sparx5: Add support for rule count by cookie")
> removed vcap_rule_iter() but not its declaration.
> Commit 8beef08f4618 ("net: microchip: sparx5: Adding initial VCAP API support")
> declared but never implemented vcap_api_set_client().
> 
> [...]

Here is the summary with links:
  - [net-next] net: microchip: Remove unused declarations
    https://git.kernel.org/netdev/net-next/c/dff96d7c0cda

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html