From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5CF3333E2 for ; Tue, 22 Aug 2023 07:30:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FF8BC433C7; Tue, 22 Aug 2023 07:30:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692689447; bh=BwHak8L0h+xrvYhw1dYhUD/XFRnn/vcZR8VKhgLGQI4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BPQFvf+DuetHCI1lK6LFxQsJ0RdA5O4USeetwhBhnlMffdIdyWZXyQRQhCM00rlJY qeFoqjosezvciSyjAcb0Slt8xUuV4WlJaXcojVV+/xZgZpyFO9ohLDHAWTFtkS9P3z 0lcLuJdR4jQ7SnOr7qVKoKe7AARsnlbWmh1rb2UkNUNxkV15As/+Q0W3gLLlsvQLil ggjyisgaSBR4tGNatqjkjbHuNYBDxhmA/vcMQX7HSwIebfufPei0WLB/qL8FCrro8P BPX5XFY7o9+P7KQlNN8/9n53loq35TJM/9XHc7saTS+3I8XaWzW+omO1bNIlI7PhkR ZfD+0IEqroXEQ== Date: Tue, 22 Aug 2023 09:30:44 +0200 From: Simon Horman To: Ido Schimmel Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, razor@blackwall.org, mlxsw@nvidia.com Subject: Re: [PATCH net-next] vxlan: vnifilter: Use GFP_KERNEL instead of GFP_ATOMIC Message-ID: <20230822073044.GN2711035@kernel.org> References: <20230821141923.1889776-1-idosch@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230821141923.1889776-1-idosch@nvidia.com> On Mon, Aug 21, 2023 at 05:19:23PM +0300, Ido Schimmel wrote: > The function is not called from an atomic context so use GFP_KERNEL > instead of GFP_ATOMIC. The allocation of the per-CPU stats is already > performed with GFP_KERNEL. > > Tested using test_vxlan_vnifiltering.sh with CONFIG_DEBUG_ATOMIC_SLEEP. > > Signed-off-by: Ido Schimmel Reviewed-by: Simon Horman