From: Simon Horman <horms@kernel.org>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
Alessio Igor Bogani <alessio.bogani@elettra.eu>,
richardcochran@gmail.com, leon@kernel.org,
rrameshbabu@nvidia.com, Arpana Arland <arpanax.arland@intel.com>
Subject: Re: [PATCH net] igb: Avoid starting unnecessary workqueues
Date: Tue, 22 Aug 2023 09:34:42 +0200 [thread overview]
Message-ID: <20230822073442.GQ2711035@kernel.org> (raw)
In-Reply-To: <20230821171927.2203644-1-anthony.l.nguyen@intel.com>
On Mon, Aug 21, 2023 at 10:19:27AM -0700, Tony Nguyen wrote:
> From: Alessio Igor Bogani <alessio.bogani@elettra.eu>
>
> If ptp_clock_register() fails or CONFIG_PTP isn't enabled, avoid starting
> PTP related workqueues.
>
> In this way we can fix this:
> BUG: unable to handle page fault for address: ffffc9000440b6f8
> #PF: supervisor read access in kernel mode
> #PF: error_code(0x0000) - not-present page
> PGD 100000067 P4D 100000067 PUD 1001e0067 PMD 107dc5067 PTE 0
> Oops: 0000 [#1] PREEMPT SMP
> [...]
> Workqueue: events igb_ptp_overflow_check
> RIP: 0010:igb_rd32+0x1f/0x60
> [...]
> Call Trace:
> igb_ptp_read_82580+0x20/0x50
> timecounter_read+0x15/0x60
> igb_ptp_overflow_check+0x1a/0x50
> process_one_work+0x1cb/0x3c0
> worker_thread+0x53/0x3f0
> ? rescuer_thread+0x370/0x370
> kthread+0x142/0x160
> ? kthread_associate_blkcg+0xc0/0xc0
> ret_from_fork+0x1f/0x30
>
> Fixes: 1f6e8178d685 ("igb: Prevent dropped Tx timestamps via work items and interrupts.")
> Fixes: d339b1331616 ("igb: add PTP Hardware Clock code")
> Signed-off-by: Alessio Igor Bogani <alessio.bogani@elettra.eu>
> Tested-by: Arpana Arland <arpanax.arland@intel.com> (A Contingent worker at Intel)
> Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2023-08-22 7:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 17:19 [PATCH net] igb: Avoid starting unnecessary workqueues Tony Nguyen
2023-08-22 7:34 ` Simon Horman [this message]
2023-08-23 0:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822073442.GQ2711035@kernel.org \
--to=horms@kernel.org \
--cc=alessio.bogani@elettra.eu \
--cc=anthony.l.nguyen@intel.com \
--cc=arpanax.arland@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=rrameshbabu@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).