From: Jakub Kicinski <kuba@kernel.org>
To: Jinjie Ruan <ruanjinjie@huawei.com>
Cc: <rafal@milecki.pl>, <bcm-kernel-feedback-list@broadcom.com>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<opendmb@gmail.com>, <florian.fainelli@broadcom.com>,
<bryan.whitehead@microchip.com>, <UNGLinuxDriver@microchip.com>,
<netdev@vger.kernel.org>, <andrew@lunn.ch>
Subject: Re: [PATCH net-next v4 3/3] net: lan743x: Return PTR_ERR() for fixed_phy_register()
Date: Tue, 22 Aug 2023 17:03:35 -0700 [thread overview]
Message-ID: <20230822170335.671f3bef@kernel.org> (raw)
In-Reply-To: <20230821025020.1971520-4-ruanjinjie@huawei.com>
On Mon, 21 Aug 2023 10:50:20 +0800 Jinjie Ruan wrote:
> fixed_phy_register() returns -EPROBE_DEFER, -EINVAL and -EBUSY,
> etc, in addition to -EIO. The Best practice is to return these
> error codes with PTR_ERR().
EPROBE_DEFER is not a unix error code. We can't return it to user
space, so propagating it from ndo_open is not correct.
> diff --git a/drivers/net/ethernet/microchip/lan743x_main.c b/drivers/net/ethernet/microchip/lan743x_main.c
> index a36f6369f132..c81cdeb4d4e7 100644
> --- a/drivers/net/ethernet/microchip/lan743x_main.c
> +++ b/drivers/net/ethernet/microchip/lan743x_main.c
> @@ -1515,7 +1515,7 @@ static int lan743x_phy_open(struct lan743x_adapter *adapter)
> &fphy_status, NULL);
> if (IS_ERR(phydev)) {
> netdev_err(netdev, "No PHY/fixed_PHY found\n");
> - return -EIO;
> + return PTR_ERR(phydev);
> }
> } else {
> goto return_error;
next prev parent reply other threads:[~2023-08-23 0:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 2:50 [PATCH net-next v4 0/3] net: Return PTR_ERR() for fixed_phy_register() Jinjie Ruan
2023-08-21 2:50 ` [PATCH net-next v4 1/3] net: bgmac: " Jinjie Ruan
2023-08-21 2:50 ` [PATCH net-next v4 2/3] net: bcmgenet: " Jinjie Ruan
2023-08-21 2:50 ` [PATCH net-next v4 3/3] net: lan743x: " Jinjie Ruan
2023-08-23 0:03 ` Jakub Kicinski [this message]
2023-08-23 7:43 ` Ruan Jinjie
2023-08-23 14:37 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822170335.671f3bef@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bryan.whitehead@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=opendmb@gmail.com \
--cc=pabeni@redhat.com \
--cc=rafal@milecki.pl \
--cc=ruanjinjie@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).