From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E67767E2 for ; Wed, 23 Aug 2023 00:52:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E200C433C7; Wed, 23 Aug 2023 00:52:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692751928; bh=sPhejjQmGXXwZiarxNfyZoYdQozrlcRiKpo4M072i+E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KgehLU77Wh2vDEKtbi4o8STryposvdc2lI9adccbIcKAg3SR40I2oAv866xgGGo4h SID8P/VAH3lGyIn8GEqChtGCycdpE7SBxiDHnIGDiu3kTLUCvklCsvhZtN4wM0nwc7 6/E8/HI5DzUOWtOpPDTfXIGstTLfGusmK4u9TRa4mYnbKmaQfAfggBWtnnTwvfwO5/ Xtu4/nlEIqE1gHexUeMEHsPYHecpBmG7CAH464IC1klszT+m16K3D239pNq6mMpTlr DyjUFlJGIlqpX3mByW1gIX9g4gIbAOxdMx8YzQJv1hWozzJkIQW3lTKQMovselvWE9 o7zxlQ8jMErPg== Date: Tue, 22 Aug 2023 17:52:07 -0700 From: Jakub Kicinski To: Amritha Nambiar Cc: netdev@vger.kernel.org, davem@davemloft.net, sridhar.samudrala@intel.com Subject: Re: [net-next PATCH v2 7/9] net: Add NAPI IRQ support Message-ID: <20230822175207.17233a9e@kernel.org> In-Reply-To: <169266034688.10199.12117427969821291880.stgit@anambiarhost.jf.intel.com> References: <169266003844.10199.10450480941022607696.stgit@anambiarhost.jf.intel.com> <169266034688.10199.12117427969821291880.stgit@anambiarhost.jf.intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 21 Aug 2023 16:25:46 -0700 Amritha Nambiar wrote: > + if (napi->irq >= 0 && (nla_put_u32(rsp, NETDEV_A_NAPI_IRQ, napi->irq))) Unnecessary brackets around nla_put