From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Florian Fainelli <florian.fainelli@broadcom.com>
Cc: stable@vger.kernel.org, Justin Chen <justin.chen@broadcom.com>,
Jakub Kicinski <kuba@kernel.org>,
Broadcom internal kernel review list
<bcm-kernel-feedback-list@broadcom.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
"open list:BROADCOM ETHERNET PHY DRIVERS"
<netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH stable 4.14] net: phy: broadcom: stub c45 read/write for 54810
Date: Tue, 22 Aug 2023 09:10:02 +0200 [thread overview]
Message-ID: <2023082252-motor-grower-5621@gregkh> (raw)
In-Reply-To: <20230821215410.3123513-1-florian.fainelli@broadcom.com>
On Mon, Aug 21, 2023 at 02:54:10PM -0700, Florian Fainelli wrote:
> From: Justin Chen <justin.chen@broadcom.com>
>
> commit 096516d092d54604d590827d05b1022c8f326639 upstream
>
> The 54810 does not support c45. The mmd_phy_indirect accesses return
> arbirtary values leading to odd behavior like saying it supports EEE
> when it doesn't. We also see that reading/writing these non-existent
> MMD registers leads to phy instability in some cases.
>
> Fixes: b14995ac2527 ("net: phy: broadcom: Add BCM54810 PHY entry")
> Signed-off-by: Justin Chen <justin.chen@broadcom.com>
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
> Link: https://lore.kernel.org/r/1691901708-28650-1-git-send-email-justin.chen@broadcom.com
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> [florian: resolved conflicts in 4.14]
> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
Thanks for these, all now queued up.
greg k-h
prev parent reply other threads:[~2023-08-22 7:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2023082134-chain-tubular-c681@gregkh>
2023-08-21 21:54 ` [PATCH stable 4.14] net: phy: broadcom: stub c45 read/write for 54810 Florian Fainelli
2023-08-22 7:10 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023082252-motor-grower-5621@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox